Journal for SilverStripe -



Working on ticket: #59 Insert Link in tiny_mce appears broken in firefox 2 (gsoc branch)
http://support.silverstripe.com/gsoc/ticket/59
1:58pm Verified problem exists with my code.
(02:40:50 PM) elijahlofgren: Now here's an interesting way to fix tab heights, simply remove the tabset divs: http://www.elijahlofgren.com/silverstripe/diffs/Interesting-Tab-Height-Fix-2007-08-17.diff
(02:54:06 PM) elijahlofgren: And with a few more changes, the AJAX action buttons fit again (left sidebar is messed up though): http://www.elijahlofgren.com/silverstripe/diffs/Tab-Heights-Almost-Fixed-2007-08-17.diff
(03:11:00 PM) elijahlofgren: And using ParseInt fixes the Left sidebar. :) http://www.elijahlofgren.com/silverstripe/diffs/Tab-Heights-Fixed-CMS-2007-08-17.diff Now to test in IE and Safari ;)
(03:22:12 PM) elijahlofgren: IE7 wants 35px for the buttons, but the fix still works! :)
(03:56:55 PM) CIA-34: Silverstripe-elijah: elijahlofgren * r169183b1e290 /layout_helpers.js:
(03:56:55 PM) CIA-34: Silverstripe-elijah: Remove my old commented out "Increase height of tabs to fill blank space"
(03:56:55 PM) CIA-34: Silverstripe-elijah: hack since I have found a better solution.
(04:01:47 PM) CIA-34: Silverstripe-elijah: elijahlofgren * r37d138d51191 /templates/TabSetFieldHolder.ss:
(04:01:49 PM) CIA-34: Silverstripe-elijah: Remove tabset div from TabSetFieldHolder.ss in order to reduce wasted space
(04:01:49 PM) CIA-34: Silverstripe-elijah: on tabs. See: http://support.silverstripe.com/gsoc/ticket/59
4:03pm Filed new ticket: http://open.silverstripe.com/ticket/1420
Ticket #1420 (new defect)

Opened 2 seconds ago
"Type mismatch" error in IE7 when "Insert Link" button in TinyMCE is clicked (gsoc branch)
(04:05:51 PM) CIA-34: Silverstripe-elijah: elijahlofgren * rd5e45db54dc6 / (css/cms_right.css javascript/LeftAndMain.js):
(04:05:51 PM) CIA-34: Silverstripe-elijah: Use padding and some JS hacks to make the AJAX action buttons fit at the
(04:05:51 PM) CIA-34: Silverstripe-elijah: bottom of the screen. Now that tabsets are no longer wrapped in a div (to
(04:05:51 PM) CIA-34: Silverstripe-elijah: reduce wasted space), there was no extra space for them.
Start Stop Elapsed
08/17/2007 03:16:50 PM   04:18:46 PM 01:01:56
  02:05:08 PM   03:14:03 PM 01:08:55
  01:54:12 PM   01:59:37 PM 00:05:25


Working on ticket: Ticket #79 Make CalendarDatePopup in Edited Since criteria not be half hidden behind right frame.
1:20pm Negative margin worked great on FF2. In IE6, the margins are too large.
1:30pm Fixed in IE7 by making table with:70% instead of width: 100%;
1:30pm Testing Safari 3 now.
1:32pm Works in Safari 3. Testing in IE6 now.
(01:44:50 PM) elijahlofgren: hmm.. My IE6 on Wine is freezing every time I try to login to silverstrie-gsoc/admin. I guess I won't use it to test on this last day of work. Works fine in IE7, FF2, and Safari 3 so I'm probably ok. ;)
(01:45:59 PM) CIA-34: Silverstripe-elijah: elijahlofgren * ref64812f70e6 /css/cms_left.css:
(01:45:59 PM) CIA-34: Silverstripe-elijah: BUGFIX: Fix ticket: "Make CalendarDatePopup in Edited Since criteria not be
(01:45:59 PM) CIA-34: Silverstripe-elijah: half hidden behind right frame." by simply applying a negative margin to it
(01:45:59 PM) CIA-34: Silverstripe-elijah: and for IE7 make the calendar table with:75% instead of 100%.
(01:45:59 PM) CIA-34: Silverstripe-elijah: http://support.silverstripe.com/gsoc/ticket/79
Start Stop Elapsed
08/17/2007 01:21:37 PM   01:50:47 PM 00:29:10
  01:07:46 PM   01:19:35 PM 00:11:49


Reading new forum/trac/wiki updates
12:04pm Very encouraging. :)
http://www.silverstripe.com/google-summer-of-code-forum/flat/2526?showPost=4154
http://www.silverstripe.com/silverstripe-development/flat/3799?showPost=4145&start=24
Start Stop Elapsed
08/17/2007 12:53:25 PM   12:59:54 PM 00:06:29
  12:03:31 PM   12:21:26 PM 00:17:55


Working on ticket #74: "Add simple search to the left site tree: simple textbox and [search] button (all on one line)" and also adding advanced search
3:13pm setMarkingFilter sounds interesting.
3:20pm And it seems to work too! :)
public function SiteTreeAsUL() {
$className = 'SiteTree';
$rootID = null;
$obj = $rootID ? $this->getRecord($rootID) : singleton($className);
// Test of search filtering capabilities. Only show pages with "Title" of "New Page"
// $obj->setMarkingFilter("Title", "New Page");
$obj->markPartialTree();
if($p = $this->currentPage()) $obj->markToExpose($p);
Commit: 61fb9efa82bd0130529ea8e5b4ea92a62036a688
Author: Elijah Lofgren Thu, 16 Aug 2007 15:23:46 -0500

Experimental way to manually filter site tree by title using:
/admin/?SiteTreeFilter=Forums @TODO Find way to not hide elements with
children only those without.
3:25pm Ah, looks like setMarkingFilterFunction will be what I need to not hide parent pages. :)
(04:22:05 PM) elijahlofgren: yay, My Satellite Internet is working again.
(04:24:42 PM) ajoneil: congrats!
(04:24:47 PM) elijahlofgren: Thanks :)
(04:25:00 PM) ajoneil: satellite for upload/download or just download?
(04:25:04 PM) elijahlofgren: both
(04:25:32 PM) ajoneil: excellent
(04:25:53 PM) ajoneil: i know a while back here in nz there was satellite internet, but you had to use it with dialup for upload
(04:26:54 PM) elijahlofgren: yeah, there was also one like that in the US. About 2 years ago we switched from dialup to a new Satellite Internet provider called WildBlue. :)
(04:27:21 PM) ajoneil: neat
(04:27:28 PM) ajoneil: its mostly DSL here in nz
(04:27:53 PM) ajoneil: with cable available in a few of the cities
(04:28:09 PM) elijahlofgren: We're too far in the woods for DSL or Cable, but at least we no longer have dialup. :)
(04:28:50 PM) ajoneil: true :)
(04:29:38 PM) ajoneil: i havent broken anything in gsoc branch yet that youve noticed?
(04:30:00 PM) CIA-34: Silverstripe-elijah: elijahlofgren * r1d0f6005f979 /code/CMSMain.php:
(04:30:00 PM) CIA-34: Silverstripe-elijah: Made experimental Site Tree filter "Show node if the filter string exists
(04:30:00 PM) CIA-34: Silverstripe-elijah: anywere in the filter paramater (ignoring case)" Using URL like:
(04:30:00 PM) CIA-34: Silverstripe-elijah: /admin/?SiteTreeFilterParameter=MetaDescription&SiteTreeFilterValue=Man
(04:30:00 PM) CIA-34: Silverstripe-elijah: @TODO: Make a 'Search' form allowing filtering the site tree on any
(04:30:02 PM) CIA-34: Silverstripe-elijah: SiteTree column. :)
(04:30:23 PM) elijahlofgren: ajoneil: I fixed 2 small things yesterday, Haven't updated fully yet today since my Internet has been down. ;)
(04:30:34 PM) ajoneil: ok cool
(04:30:40 PM) ajoneil: time for more merging :P
(04:31:05 PM) elijahlofgren: which reminds me, I need to commit a bugfix for something I broke yesterday. :)
(04:32:28 PM) ajoneil: summer of code is nearly finished right?
(04:32:39 PM) elijahlofgren: yes, tomorrow will be my last day of work.
(04:32:54 PM) elijahlofgren: It's gone by so quickly. I've really enjoyed it.
(04:32:55 PM) halkyon: already?!
(04:32:59 PM) halkyon: i thought it just started ;-)
(04:33:01 PM) elijahlofgren: :)
(04:34:12 PM) halkyon: well, we didn't quite get the whole report finished
(04:34:17 PM) halkyon: but we got a good load of work done ;-)
(04:34:32 PM) halkyon: certainly a fantastic start - really appreciate all the hard work Elijah :-)
(04:35:02 PM) elijahlofgren: Thanks. :) indeed. Maybe more issues will be fixed by the new UI design.
(04:35:16 PM) halkyon: that's what I was thinking too
(04:35:37 PM) halkyon: hopefully we fix the current problems without introducing too many new usability issues
(04:35:39 PM) halkyon: :-)
(04:35:51 PM) halkyon: the fact we've got the design on the forum helps a lot more than closed discussion
(04:38:35 PM) elijahlofgren: agreed. I've got to run and do a few things my mom asked me to do. Be back soonish. ;)
(04:38:49 PM) halkyon: sweet, okay
(04:40:29 PM) Matt`SS: just about to send out an email to all gsocers
(04:40:32 PM) Matt`SS: re. deadlines
(04:42:20 PM) Matt`SS: and off it goes
(04:42:39 PM) ***qhox reads
(04:44:27 PM) Matt`SS: missed a big part, sending another email now :P
(04:44:38 PM) WebGuest463 [n=535eaecd@littleted.silverstripe.com] entered the room.
(04:45:54 PM) WebGuest463 left the room (quit: Client Quit).
(04:51:38 PM) mode (+v elijahs-supybot ) by ajoneil
(04:53:36 PM) ***qhox about to read again
(04:53:59 PM) Matt`SS: heh
(04:58:15 PM) Matt`SS: sent
(04:58:52 PM) Matt`SS has changed the topic to: Nominate us for New Zealand Open Source Awards (http://nzosa.org.nz) and [international] CMS Awards; http://www.silverstripe.com/international-open-source-cms-awards-nominate-us/ || New modules discussion: http://www.silverstripe.com/modules-discussion/ || Summer of Code is almost over! Thanks to everyone who has participated!
(05:22:42 PM) halkyon: yeah, it's been great
(05:22:45 PM) halkyon: :)
(05:26:05 PM) qhox: it has, quite a good learning experience
(05:26:20 PM) qhox: and its fun to work on a good code base
(05:28:18 PM) elijahlofgren: Indeed. I enjoy coding on SilverStripe more than CMS Made Simple because SilverStripe's code is so nice. (Helps that SS is PHP5 only). :)
(05:40:53 PM) ajoneil: i for one am glad that php4 support is finally being dropped
(06:00:22 PM) ***elijahlofgren searches for a way to get the Behaviour.apply() call in this code to work:
$('sitetree').innerHTML = response.responseText;
Behaviour.apply( $('sitetree') );
(06:01:48 PM) Matt`SS: elijahlofgren: Behaviour.reapply()?
(06:01:51 PM) Matt`SS: Does that exist? :P
(06:03:45 PM) elijahlofgren: Matt`SS: I don't think so. "If you modify the dom: You can call Behaviour.apply() from your scripts to re-apply the rules to any new elements." http://www.bennolan.com/behaviour/
(06:03:52 PM) elijahs-supybot: Title: Behaviour : Using CSS selectors to apply Javascript behaviours (at www.bennolan.com)
(06:04:48 PM) elijahlofgren: Looks like someone had a similar problem and resolved it: http://www.nabble.com/Reapplying-Behaviour-after-Ajax.Updater-have-added-new-IDs-t2577126.html I think I'll try their fix.
(06:04:53 PM) elijahs-supybot: Title: Nabble - Reapplying Behaviour after Ajax.Updater have added new IDs (at www.nabble.com)
(06:09:06 PM) ajoneil: go go supybot :D
(06:09:08 PM) halkyon: I for one welcome our PHP5 overlords
(06:09:10 PM) halkyon: :D
(06:09:13 PM) ajoneil: hehe
(06:09:15 PM) ajoneil: classic
(06:11:40 PM) Matt`SS: Ahh sweet as
(06:11:51 PM) Matt`SS: I thought I saw it being called somewhere, probably just mis-read it :)
(06:12:48 PM) ajoneil: elijahlofgren: did you get a chance to look at the frame resizing and tinymce links yet?
(06:13:14 PM) elijahlofgren: ajoneil: no, but I'm wondering, since there will be a UI redesign, is it worth looking into?
(06:14:40 PM) ajoneil: hmm well the UI redesign won't be happening for a while
(06:14:54 PM) ajoneil: and that bug is particularly annoying for me on widescreen :P it's a personal thing :P
(06:15:11 PM) ajoneil: when i use the image inserter i have like half and inch of the content window visible
(06:15:15 PM) ajoneil: *an
(06:15:35 PM) ajoneil: halkyon: your opinion?
(06:15:41 PM) elijahlofgren: ajoneil: ah, ok. I'll maybe try looking into it tomorrow. I'm entrenched in working on a Site Tree search filter right now. ;)
(06:16:00 PM) ajoneil: yeah, that search will be pretty neat :D
(06:16:51 PM) elijahlofgren: amazing! I simply had to change Behaviour.apply( $('sitetree') ); to Behaviour.apply();
(06:17:21 PM) ajoneil: hah excellent. Love the one line fixes :D
(06:17:51 PM) elijahlofgren: Now I could probably go back and change the Newletter Recipient Import to automatically reload the recipients list. I struggled for so long on that. But I think I'll just continue working on Site Tree filter since I only have 1 more day of SoC coding left.
(06:18:43 PM) Matt`SS: Hehe, true
(06:18:44 PM) ajoneil: yeah :S
(06:18:48 PM) ajoneil: wow over already
(06:19:09 PM) Matt`SS: I was going to add in that email about submitting .diffs elijahlofgren, good luck to you submitting them all :P
(06:19:19 PM) Matt`SS: but you found a more elegant solution using git :]
(06:19:23 PM) elijahlofgren: :)
(06:21:13 PM) halkyon: ajoneil: I'd say it should be looked at if the UI redesign isn't for a while yet
(06:21:41 PM) ajoneil: git is pretty cool
(06:21:48 PM) ajoneil: i was playing with the other day
(06:23:41 PM) Matt`SS: not at least until Ingo gets back
(06:23:47 PM) Matt`SS: and probably not right away
(06:24:23 PM) halkyon: yeah, Ingo should definitely put that together
(06:24:29 PM) halkyon: it's an intense piece of work
(06:24:34 PM) halkyon: :-)
(06:31:38 PM) ajoneil: ingo needs to hurry up and come back :(
(06:33:42 PM) ajoneil: qhox: how goes the reporting? i haven't really got a chance to look at it
(06:34:06 PM) qhox: its coming along nicely
(06:34:07 PM) qhox: im fighting with 3rd party js libs right now
(06:34:10 PM) qhox: its fun
(06:35:07 PM) ajoneil: hehe yeah
(06:43:21 PM) Matt`SS: sounds like it :>
(06:53:29 PM) CIA-34: Silverstripe-elijah: elijahlofgren * r322fcfe7487e / (5 files in 4 dirs): (log message trimmed)
(06:53:29 PM) CIA-34: Silverstripe-elijah: Make clicking on the 'Search' button show a Drop-Down with 'Title' and 'Description' options (more from SiteTree table to be easily added later).
(06:53:29 PM) CIA-34: Silverstripe-elijah: and a 'Filter' button that filters the Site Tree when clicked (always showing pages with children in case the filter matches a child).
(06:53:31 PM) CIA-34: Silverstripe-elijah: TODO: 1. Test in IE6, IE7, and Safari 3
(06:53:33 PM) CIA-34: Silverstripe-elijah: 2. Add a search blank and button that searches Titles, URL, Content, etc.
(06:53:35 PM) CIA-34: Silverstripe-elijah: 3. Make Filters only show when added using 'Add Criteria' button.
(06:53:37 PM) CIA-34: Silverstripe-elijah: 4. Add followin optional criteria: 'Edited Since' (using DatePicker), 'Page Type' using same drop-down as
(06:54:18 PM) elijahlofgren: 'Create', and 'Status' with 'Deleted', 'Draft', and 'Published' drop-down options
(06:55:08 PM) ajoneil: excellent
(06:55:16 PM) Matt`SS: beat me to it :]
(06:55:17 PM) ajoneil: you might wanna avoid commiting to svn just now
(06:55:29 PM) ajoneil: i cant guarantee it isnt broken :P
(06:55:50 PM) elijahlofgren: ajoneil: ok, thanks for the warning. I'm just working in my local git repo for now. :)
(06:56:09 PM) ajoneil: k, i should be finished merging soonish
(06:58:49 PM) elijahlofgren: Filtering Site Tree in IE7 gives this error: "Stack overflow at line: 0" So helpful. ;)
(07:01:32 PM) Matt`SS: I had heard that Visual Studios helps immensely, but I haven't needed to install it yet
(07:01:37 PM) elijahlofgren: Matt`SS: Check out the last 2 links here: http://doc.silverstripe.com/doku.php?id=javascript#useful_tools_for_debugging_in_internet_explorer
(07:01:44 PM) elijahlofgren: It comes with MS Office 2003 :)
(07:01:45 PM) elijahs-supybot: Title: javascript [SilverStripe Documentation] (at doc.silverstripe.com)
(07:01:50 PM) Matt`SS: Ah, cool
(07:01:55 PM) Matt`SS: And didn't feel like playing with it at 7pm last night LO
(07:01:57 PM) Matt`SS: :P even
(07:02:04 PM) Matt`SS: Cheers for the link :]
(07:19:49 PM) Matt`SS: I find it quite annoying that every Windows update now requires me to restart Windows
(07:19:53 PM) Matt`SS: Including the new WMP 11
(07:20:36 PM) Matt`SS: I mean it's a media player, why does it need to hook so deep into the Windows kernal that it needs to set stuff up before Windows is loaded?
(07:20:42 PM) halkyon: yeah
(07:20:48 PM) halkyon: that's pretty strange
(07:21:01 PM) halkyon: apple doesn't ask to restart unless it's core changes
(07:21:09 PM) halkyon: itunes, quicktime etc are all non-restarters
(07:21:29 PM) Matt`SS: to be fair, most of windows is too
(07:21:32 PM) Matt`SS: this just confused me
(07:21:41 PM) halkyon: maybe there's core changes for WMP?
(07:22:11 PM) halkyon: then again, Vista can force you to restart without being able to stop it, MS is weird
(07:22:16 PM) Matt`SS: kernal changes*
(07:22:16 PM) halkyon: did you see that video? :p
(07:22:21 PM) Matt`SS: i saw yeah
(07:22:26 PM) Matt`SS: That's nothing new
(07:22:37 PM) Matt`SS: XP has done that to me a few times, once a couple of days ago even
(07:22:38 PM) halkyon: is it? XP doesn't do that AFAIK
(07:22:45 PM) halkyon: for me at least
(07:23:11 PM) Matt`SS: Yep, I've come back in the morning to see a message saying 'windows had to automatically restart your computer after installing an important update'
(07:23:19 PM) Matt`SS: An unsaved notepad document got lost
(07:23:21 PM) halkyon: that's just poor, what if I was about to sign off a million dollar project?
(07:23:22 PM) halkyon: FAIL
(07:23:25 PM) halkyon: haha
(07:34:39 PM) elijahlofgren: ok, so IE7 doesn't like me replacing the Site Tree and then calling SiteTree.applyTo('#sitetree'); or Behaviour.apply() both result in Stack Overflow At Line 0 Error Prompt. :/
(07:46:09 PM) ***elijahlofgren decides to test on native IE7 and need to unplug network cable to do so. BBL.
7:52pm Same error. :(
(08:10:08 PM) elijahlofgren: Ok, after wasting an hour of my time trying to get rid of the Stack Overflow At Line 0 Error Prompt in IE, I have removed all SS modules except core ones, and reinstalled SilverStripe (thus making me only have 5 pages in the site tree). No more errors in IE7. Back to working on features now.
8:15pm Works in IE6 and Safari 3 also. NOTE TO SELF: Re-install SS if getting IE stack overflow errors!!!!!!!!!!!!
(08:37:24 PM) CIA-34: Silverstripe-elijah: elijahlofgren * rb5f2aa1f3fc7 /javascript/LeftAndMain_left.js:
(08:37:24 PM) CIA-34: Silverstripe-elijah: Use Ajax.SubmitForm instead of Ajax.Request to greatly reduce code and
(08:37:24 PM) CIA-34: Silverstripe-elijah: maintain future extensibility for submitting SiteTreeFilterForm.
(08:39:21 PM) CIA-34: Silverstripe-elijah: elijahlofgren * r82395076cb6d /javascript/CMSMain_left.js:
(08:39:22 PM) CIA-34: Silverstripe-elijah: When the 'Search' button is clicked again to close the search section (or
(08:39:22 PM) CIA-34: Silverstripe-elijah: 'Create' or 'Batch Actions' is clicked): Unfilter the Site Tree and show
(08:39:22 PM) CIA-34: Silverstripe-elijah: all items again.
(08:41:37 PM) Matt`SS: Awesome
(08:41:47 PM) Matt`SS: Right, time to plod off to Uni now
(08:41:56 PM) elijahlofgren: Matt`SS: goodbye
(08:42:57 PM) Matt`SS: Catch you tomorrow elijahlofgren. Have a good night :)
(08:43:09 PM) elijahlofgren: Matt`SS: you too. Have a great rest of the day over there. :)
(09:13:40 PM) ajoneil: elijahlofgren: well, ive fixed what i've broken i think, but i still have more merges to do :P
(09:14:07 PM) elijahlofgren: ok, Thanks for letting me know. It'll still be a little while before I commit the search stuff. ;)
(09:14:19 PM) ajoneil: k, ill tell you when i finish merging!
(10:12:26 PM) CIA-34: silverstripe: sminnee * r40392 /open/modules/ (12 files in 6 dirs): Added HTTPResponse object, to encapsulate Controller responses for aid testing and other 'quirky' uses of Controllers
(10:34:15 PM) ajoneil: elijahlofgren: i've just finished merging, now i gotta fix the breakage :P
(10:34:42 PM) elijahlofgren: ajoneil: ok, Thanks for letting me know. I'll hopefully be ready to commit soonish since I need to go to bed soon.
(10:37:51 PM) ajoneil: ok,, i just fixed db/build
(10:37:55 PM) ajoneil: it's super fast now
(10:37:59 PM) ajoneil: sam is the man :D
(10:38:02 PM) elijahlofgren: cool :)
(10:41:29 PM) ajoneil: hmm iim not sure how to make the comment administration look the same as the rest of the areas?
(10:41:56 PM) elijahlofgren: Where does it currently show up? (I haven't seen it yet)
(10:42:13 PM) ajoneil: its a tab in the CMS
(10:42:27 PM) CIA-34: silverstripe: sminnee * r40400 /open/modules/sapphire/trunk/core/control/HTTPResponse.php: Added missing file from r40392
(10:42:29 PM) ajoneil: like, another section
(10:43:20 PM) ajoneil: will you have time to do it before Summer of Code ends?
(10:43:47 PM) elijahlofgren: Sorry, no. I've still got stuff to do tomorrow that I haven't finished.
(10:44:00 PM) ajoneil: ok fair enough
(10:44:02 PM) ajoneil: ok hmm
(10:57:13 PM) ajoneil: ok, that should've fixed it :)
(11:01:24 PM) CIA-34: Silverstripe-elijah: elijahlofgren * r3503f4f45e96 / (6 files in 5 dirs):
(11:01:24 PM) CIA-34: Silverstripe-elijah: By default, when 'Search' button is clicked show a simple 'Search' text
(11:01:24 PM) CIA-34: Silverstripe-elijah: input and Search button.
(11:01:24 PM) CIA-34: Silverstripe-elijah: Add 'Add Criteria...' drop-down allowing searching on 'Page Type',
(11:01:24 PM) CIA-34: Silverstripe-elijah: 'Status', 'MetaDescription', and 'MetaKeywords'. More columns from the
(11:01:27 PM) CIA-34: Silverstripe-elijah: SiteTree table can easily be added by adding to the
(11:01:29 PM) CIA-34: Silverstripe-elijah: CMSMain::$site_tree_filter_options array.
(11:52:26 PM) CIA-34: silverstripe: aoneil * r40410 /open/modules/sapphire/trunk/core/model/ (Database.php MySQLDatabase.php): Fixed bugs in db/build (merged from gsoc branch, r40402)
(11:52:27 PM) CIA-34: silverstripe: jshipman * r40411 /open/modules/mashups/trunk/code/FlickrService.php: Flicker mashup was producing an error when a user could not be found. Now throws an exception, rather than an error.
(12:02:27 AM) CIA-34: silverstripe: aoneil * r40414 /open/thirdparty:
(12:04:31 AM) CIA-34: Silverstripe-elijah: elijahlofgren * rf731a7965f3b / (3 files in 3 dirs):
(12:04:31 AM) CIA-34: Silverstripe-elijah: Add 'Edited Since' CalendarDateField as optional Search Criteria and make
(12:04:31 AM) CIA-34: Silverstripe-elijah: each search criteria be required to be found for a page to be matched (of
(12:04:31 AM) CIA-34: Silverstripe-elijah: course pages with children still always match).
(12:11:11 AM) elijahlofgren: It seems forum might need some files deleted:
(12:11:12 AM) elijahlofgren: Warning: Warning: there are two 'BBCodeParser' files: '/var/www/silverstripe-gsoc-straight-svn/sapphire/parsers/BBCodeParser.php' and '/var/www/silverstripe-gsoc-straight-svn/forum/code/BBCodeParser.php'. This might mean that the wrong code is being used. in /var/www/silverstripe-gsoc-straight-svn/sapphire/core/ManifestBuilder.php on line 213
(12:11:12 AM) elijahlofgren: Warning: Warning: there are two 'TextParser' files: '/var/www/silverstripe-gsoc-straight-svn/sapphire/parsers/TextParser.php' and '/var/www/silverstripe-gsoc-straight-svn/forum/code/TextParser.php'. This might mean that the wrong code is being used. in /var/www/silverstripe-gsoc-straight-svn/sapphire/core/ManifestBuilder.php on line 213
(12:22:26 AM) CIA-34: silverstripe: aoneil * r40416 /open/modules/jsparty/trunk: Change tinymce external to point to the open branch
(12:24:09 AM) elijahlofgren: ajoneil: Should I make the Site Tree search results simply be a flat list? That way I don't have to hard code it to show all pages that have children. It will probably be easier to understand if only pages matching the search are listed.
(01:09:55 AM) ***elijahlofgren gives up on making results flat list. Going to just always show nodes with parents.
------------------------------------------------------------------------
r40431 | elofgren | 2007-08-17 01:25:14 -0500 (Fri, 17 Aug 2007) | 7 lines

NEW FEATURE: When 'Search' button is clicked show a simple search text input and button which allow for filtering the Site Tree by searching the URL, Title, Menu Title, and Content.
Also show an 'Add criteria...' drop-down with 'Page Type', 'Status', 'Description', and 'Keywords' options which allow for more fine grained filtering based on columns in the SiteTree table.
In addition add an 'Edited Since' option which uses a CalendarDatePicker which allows for filtering pages based on when they were last edited.
NOTE: Pages that have children will always be shown whether they match the filter or not, in case one of their children matches the filter. It would probably be better to switch to a flat
display of the results.
More info: http://www.silverstripe.com/google-summer-of-code-forum/flat/2526

------------------------------------------------------------------------
1:38pm Posted here: http://www.silverstripe.com/google-summer-of-code-forum/flat/2526?showPost=4139#post4139
(02:00:12 AM) CIA-34: Silverstripe-elijah: elijahlofgren * rc8b239ff2c4e / (3 files in 3 dirs):
(02:00:12 AM) CIA-34: Silverstripe-elijah: Add 'Show only changed pages' checkbox above 'Publish the selected pages'
(02:00:12 AM) CIA-34: Silverstripe-elijah: button under 'Bulk Actions'. Note: Pages that have children will always be
(02:00:12 AM) CIA-34: Silverstripe-elijah: shown in case their children have been changed. Suggested here:
(02:00:12 AM) CIA-34: Silverstripe-elijah: http://www.silverstripe.com/silverstripe-development/flat/3799?showPost=4092#post4092
(02:00:19 AM) elijahs-supybot: Title: SilverStripe Development (at www.silverstripe.com)
(02:24:05 AM) elijahlofgren: Progress update: http://www.elijahlofgren.com/soc/ Goodnight all! :)
(02:24:12 AM) elijahs-supybot: Title: Elijah s 2007 Google Summer of Code Experience (at www.elijahlofgren.com)
Start Stop Elapsed
08/16/2007 09:30:54 PM 08/17/2007 02:12:27 AM 04:41:33
08/16/2007 05:49:03 PM   09:18:58 PM 03:29:55
  05:10:00 PM   05:31:48 PM 00:21:48
  04:12:27 PM   04:39:11 PM 00:26:44
  03:05:59 PM   04:11:23 PM 01:05:24


Working on fixing 'Save & Publish' bug
2:35pm Create new page, click "Save & Publish", get this error:
Fatal error: Call to a member function Actions() on a non-object in /var/www/silverstripe-gsoc/cms/code/LeftAndMain.php on line 489
Start Stop Elapsed
08/16/2007 02:35:40 PM   03:01:34 PM 00:25:54


Trying to find way to disable sitemaps
TODO: Find way to disable sitemaps so that if I'm offline, I don't get this error:

ERROR:Error 2: fsockopen() [function.fsockopen]: php_network_getaddresses

: getaddrinfo failed: Name or service not known

At l203 in /var/www/silverstripe-gsoc/sapphire/core/HTTP.php

fsockopen(www.google.com,80,0,)

line 203 of HTTP.php

HTTP::sendRequest(www.google.com,/webmasters/sitemaps/ping,sitemap=http%3A%2F%2Flocalhost%2Fsilverstripe-gsoc

%2F%2Fsitemap.xml)

line 75 of Sitemap.php

Sitemap::Ping()

line 429 of CMSMain.php

CMSMain->performPublish(Page)

line 462 of LeftAndMain.php

LeftAndMain->save(Array,Form)

line 114 of Controller.php

Controller->run(Array)

line 48 of Director.php

Director::direct(/admin/)

line 101 of main.php
2:34pm Nice:

/**
* Disables pings to google when the sitemap changes
* To use this, in your _config.php file simply include the line
* Sitemap::DisableGoogleNotification();
*/
static function DisableGoogleNotification()
{
self::$pings = false;
}
Start Stop Elapsed
08/16/2007 02:28:47 PM   02:35:40 PM 00:06:53


Reading new forum/trac/wiki updates
Start Stop Elapsed
08/16/2007 12:32:09 PM   12:33:16 PM 00:01:07


Preparing blog post progress report of today's progress
(12:11:43 AM) Matt`SS: Heh, haven't done terribly much. Added three features in a weekend then spent more than two weeks bug-fixing them :P
Start Stop Elapsed
08/16/2007 12:11:42 AM   12:17:48 AM 00:06:06


Working on post link patch for forum module
(11:41:50 PM) ***elijahlofgren decides to finally try coding a quick patch he's been wanting to make for a while, making the post titles (e.g. "Re: New SilverStripe CMS concepts") into links which allow easy copying of a specific post's link instead of using Firebug to manually find the post id. :)
(11:42:05 PM) Matt`SS: oh yes please :P
(11:42:25 PM) Matt`SS: also, maybe adding an image after them like the right-pointing arrow to make it obvious it is a link
(11:42:35 PM) elijahlofgren: sounds good :)
(11:42:51 PM) wakeless: hey guys,
(11:43:05 PM) wakeless: was wondering if anyone had a look at the prototype 1.5 patch I put on the forums :)
(11:44:20 PM) Matt`SS: I have to fix some stuff in the forum (probably next week) anyway, so I'll throw it in there
(11:44:27 PM) Matt`SS: wakeless: I haven't yet, do you have a link?
(11:45:09 PM) wakeless: http://dev.wakeless.net/prototype1.5.diff
(11:45:30 PM) wakeless: that's patched against our SVN so it might not apply too well.
(11:45:53 PM) elijahlofgren: wakeless: wow, that looks like a lot of work!
(11:46:00 PM) wakeless: nah.
(11:46:28 PM) wakeless: it looks like it cause it replaces prototype1.4 with 1.5
(11:46:32 PM) wakeless: I didn't do any work
(11:47:41 PM) Matt`SS: wakeless: Cool, cheers. I'll pass it on to Andy/Sam who would be the ones to merge it in
(11:47:50 PM) elijahlofgren: wakeless: this sounds great! :)
(11:48:41 PM) wakeless: yeah... I've also got another bit of code.
(11:48:56 PM) wakeless: let me give some background.
(11:49:07 PM) wakeless: We are basically building a site that doesn't use the CMS backend.
(11:49:18 PM) wakeless: basically just uses DataObjects and Templates.
(11:49:49 PM) wakeless: and currently, if you use the URL
(11:49:54 PM) wakeless: Controller/Function/ID
(11:50:07 PM) Matt`SS: wakeless: Have passed it on to Sam and Andy - one of those will look over it and hopefully merge it into trunk
(11:50:18 PM) wakeless: more like Product/Function/ID (where product inherits DataObject)
(11:50:32 PM) wakeless: it will call Function on an Empty Product DO.
(11:50:47 PM) wakeless: so I've rewritten Director so that it first looks for Product_Controller
(11:51:20 PM) wakeless: which should be a contentController and loads a Product DO into the ContentController
(11:51:30 PM) wakeless: and calls function on the Controller rather than the DO.
(11:52:49 PM) wakeless: I think it separates the Control away from the Model quite nicely.
(11:56:59 PM) elijahlofgren: wakeless: hmm.. perhaps you might want to post the code to this topic? http://www.silverstripe.com/general-discussion/flat/1929 It sounds quite nice, but I don't understand it fully. ;)
(11:57:07 PM) elijahs-supybot: Title: General Discussion (at www.silverstripe.com)
(11:57:33 PM) wakeless: haha...
(11:57:41 PM) wakeless: I've chimed in at the bottom.
(11:57:42 PM) wakeless: :)
(11:58:29 PM) elijahlofgren: posting a patch might make it more likely for Sam or someone to accept it ;)
(12:10:23 AM) elijahlofgren: Matt`SS: Patch posted http://open.silverstripe.com/ticket/1417 :)
(12:10:31 AM) elijahs-supybot: Title: #1417 (Patch: Links each Forum Post Title to itself (along with right arrow icon)) – SilverStripe Open Source Trac – Trac (at open.silverstripe.com)
(12:10:46 AM) Matt`SS: Awesome, thanks man
(12:11:04 AM) elijahlofgren: Matt`SS: you're welcome. Thanks for all the work you done on the forums. :)
Start Stop Elapsed
08/15/2007 11:42:12 PM 08/16/2007 12:11:42 AM 00:29:30


Working on Ticket: #73 Rename 'Delete' button to 'Bulk Actions' and add 'Publish selected pages' button
11:55am I think I just fixed: http://support.silverstripe.com/gsoc/ticket/31 "Changed icon sometimes shows after "Save & Publish" button is clicked"
11:155am Just filed: "Changed icon only shows after Save button is clicked twice" http://support.silverstripe.com/gsoc/ticket/76
(12:25:34 PM) CIA-34: Silverstripe-elijah: elijahlofgren * rfe968353348f /code/LeftAndMain.php:
(12:25:34 PM) CIA-34: Silverstripe-elijah: BUGFIX: Fix the following bugs:
(12:25:34 PM) CIA-34: Silverstripe-elijah: "Changed icon only shows after Save button is clicked twice" http://support.silverstripe.com/gsoc/ticket/76
(12:25:34 PM) CIA-34: Silverstripe-elijah: "Changed icon sometimes shows after "Save & Publish" button is clicked" http://support.silverstripe.com/gsoc/ticket/31
(12:30:20 PM) elijahlofgren: Note to self, check what branch you are on, if applying a patch fails. A patch against the gsoc branch likely won't apply to trunk! ;)
12:44pm To Do: Try to find why publish selected pages button updating of icons is not working
(01:34:36 PM) CIA-34: Silverstripe-elijah: elijahlofgren * reb695667b8e1 / (5 files in 5 dirs):
(01:34:36 PM) CIA-34: Silverstripe-elijah: 'Publish selected pages' button now works. @TODO: Make it only show after
(01:34:36 PM) CIA-34: Silverstripe-elijah: 'Batch Actions' button is clicked.
2:00pm working on above @TODO.
3:40pm Filed ticket: " Ticket #77 (assigned defect) Verify that FormResponse::status_message($message); is broken, if so, file a ticket (with example code)"
http://support.silverstripe.com/gsoc/ticket/77
(04:02:37 PM) CIA-34: Silverstripe-elijah: elijahlofgren * r6065d23bdf70 / (4 files in 3 dirs):
(04:02:38 PM) CIA-34: Silverstripe-elijah: 'Publish the selected pages' button now shows only when 'Batch Actions'
(04:02:38 PM) CIA-34: Silverstripe-elijah: button is clicked. TODO: Remove code duplication and test in IE6, IE7,
(04:02:38 PM) CIA-34: Silverstripe-elijah: and Safari 3.
(04:05:35 PM) elijahlofgren: I need to go do some things to prepare for guests that are coming. Will hopefully be back later. ;)
4:45pm Testing in IE7.
(04:56:28 PM) CIA-34: Silverstripe-elijah: elijahlofgren * r73fa42dde937 /javascript/LeftAndMain_left.js:
(04:56:28 PM) CIA-34: Silverstripe-elijah: BUGFIX: Remove trailing ',' from _HANDLER_FORMS declaration. (I wonder
(04:56:28 PM) CIA-34: Silverstripe-elijah: why Firebug doesn't alert me to this problem, but Microsoft Script Editor
(04:56:28 PM) CIA-34: Silverstripe-elijah: does). Hmm.... Maybe I'll try: http://www.jslint.com/
(04:56:31 PM) elijahs-supybot: Title: JSLint, The JavaScript Verifier (at www.jslint.com)
5:00pm Yay, Works in IE7! :) On to removing code duplication. :)
(05:10:54 PM) kuribas: Is it possible to make multilingual websites with silverstripe?
(05:12:15 PM) Hayden_SS[1]: We are working on localisation and internationalisation at the moment as part of the Summer of Code
(05:13:31 PM) kuribas: I don't mind having an english CMS system, but I'd like to have my final pages in multiple languages.
(05:14:01 PM) kuribas: Is that currently not possible?
(05:18:58 PM) CIA-34: Silverstripe-elijah: elijahlofgren * rd3869a94f8a7 /javascript/CMSMain_left.js:
(05:18:58 PM) CIA-34: Silverstripe-elijah: Remove duplicated code between publishpage & deletepage and move it to
(05:18:58 PM) CIA-34: Silverstripe-elijah: batchActionGlobals.getCsvIds() which is called by both.
(05:18:58 PM) CIA-34: Silverstripe-elijah: TODO: Test the new 'Publish the selected pages' button in IE6, IE7, Safari 3
(05:18:58 PM) CIA-34: Silverstripe-elijah: and commit to SVN! :)
(05:19:10 PM) elijahlofgren: kuribas, no that I know of. It's being worked on for 2.1 I think.
(05:19:59 PM) elijahlofgren: Friends have arrived for supper. I may get a chance to do some more coding later tonight. Goodbye for now! ;)
(05:20:28 PM) kuribas: Bye
(08:14:33 PM) qhox: anyone know if canvas elements in a ajax response can be rendered?
(08:18:55 PM) elijahlofgren: qhox: hmmm.. A google search turned up this: http://cse-mjmcl.cse.bris.ac.uk/blog/2006/01/21/1137842060497.html I'm reading it now...
(08:19:02 PM) elijahs-supybot: Title: Combining AJAX, Canvas tag and SVG - Mark McLaren's Weblog (at cse-mjmcl.cse.bris.ac.uk)
(08:19:35 PM) elijahlofgren: and the linked example seems to be AJAX canvas elements being rendered: http://redsquirrel.com/dave/play/ajaxtrains.html
(10:06:27 PM) Matt`SS: elijahlofgren: How have you been going today?
(10:11:56 PM) elijahlofgren: Matt`SS: I've been doing good. I got the new 'Publish selected pages' button working. Now I need to test it in IE6, IE7, Safari 3 and commit it. We had friends over for dinner, so I've been away for about 5 hours. ;)
(10:12:04 PM) elijahlofgren: Matt`SS: how are you doing?
(10:12:17 PM) Matt`SS: Ah, awesome :)
(10:12:29 PM) Matt`SS: Been working on non-SS projects all day heh
(10:22:22 PM) elijahlofgren: yay! Works in IE7, hopefully IE6 will be just as cooperative. ;)
(10:22:57 PM) Matt`SS: Haha
(10:23:01 PM) Matt`SS: I hope so too :P
(10:25:06 PM) henno: IE6 != cooperative
(10:25:59 PM) elijahlofgren: henno: I agree, hopefully IE6 will be dead long before 2009!
(10:26:05 PM) Hayden_SS[1]: I hear IE6 caused the extinction of the Dodo in the first place.
(10:27:53 PM) elijahlofgren: umm.. Why doesn't IE6 load any pages to edit? Why don't the checkboxes appear? Hmm.. I know! "IE6 != cooperative" IE6 didn't fail to make life a little more interesting.
(10:29:48 PM) Matt`SS: Absolutely
(10:35:07 PM) elijahlofgren: Rebooted IE6, and it works. Must be IE6 under Wine doesn't like 100% CPU usage while starting (I was closing IE7 and starting Safari 3 under VmWare at the same time). Yay, no IE6 debugging for me tonight. :)
(10:37:31 PM) Matt`SS: haha, cool
(10:37:35 PM) Matt`SS: That's alright then :P
(10:39:10 PM) elijahlofgren: quite strange. I sometimes get this returned by the 'Publish selected pages' AJAX call: Behaviour.register({ '#switchView a' : { onclick : function() { var w = window.open(this.href,windowName(this.target)); w.focus(); return false; } } }); function windowName(suffix) { var base = document.getElementsByTagName('base')[0].href.replace('http://','').replace(/\//g,'_').replace(/\./g,'_'); return base + suffix; } window.name = windowName('site');
(10:39:24 PM) elijahlofgren: time to do some googling and grepping.
(10:40:18 PM) elijahlofgren: 1st and only google result? svn.silverstripe.com/open/modules/sapphire/trunk/core/control/ContentController.php :)
(10:40:52 PM) Matt`SS: hahaha
(10:40:55 PM) Matt`SS: Excellent
(10:41:11 PM) Matt`SS: bigted getting hammered obviously paid off then :P
(10:43:09 PM) elijahlofgren: ok, that code is in SilverStripeNavigator(). Hmm... Something to do with publishing must call that somehow...
(10:44:48 PM) elijahlofgren: aha, maybe I just need to add a ';' after a call to $('sitetree').setNodeTitle() and statusMessage() :)
(10:47:08 PM) CIA-34: Silverstripe-elijah: elijahlofgren * r345e7a9d0cb3 /code/CMSMain.php:
(10:47:08 PM) CIA-34: Silverstripe-elijah: BUGFIX: Add a ';' after calls to $('sitetree').setNodeTitle() and
(10:47:08 PM) CIA-34: Silverstripe-elijah: statusMessage() to fix 'Error in Ajax evaluator on line undefined: Parse
(10:47:08 PM) CIA-34: Silverstripe-elijah: error' in Safari 3 when 'Publish the selected pages' button is clicked.
11:05pm Reading: http://www.silverstripe.com/silverstripe-development/flat/3799?showPost=4070
(11:10:55 PM) CIA-34: Silverstripe-elijah: elijahlofgren * rf8c0306000e6 /templates/Includes/CMSMain_left.ss:
(11:10:55 PM) CIA-34: Silverstripe-elijah: Remove 1px border from bottom of 'Delete the selected pages' and 'Publish
(11:10:55 PM) CIA-34: Silverstripe-elijah: the selected pages' forms.
(11:24:42 PM) elijahlofgren: :/ Seems the post-#### ids have been removed from the SilverStripe forum HTML source, so it's no longer possible to link to specific posts. I guess it's time for me to file a feature request or quickly create a patch to add that back in.
(11:25:50 PM) elijahlofgren: wait a minute.
(11:26:03 PM) elijahlofgren: It's on in 'reply' mode that that happens. :)
(11:26:06 PM) elijahlofgren: *only
------------------------------------------------------------------------
r40208 | elofgren | 2007-08-15 23:27:21 -0500 (Wed, 15 Aug 2007) | 5 lines

NEW FEATURE: Replace the 'Delete...' button with a 'Batch Actions' button and add a 'Publish the selected pages' button.
See: http://www.silverstripe.com/google-summer-of-code-forum/flat/1636?showPost=1859#post1859
And: http://www.silverstripe.com/silverstripe-development/flat/3799?showPost=4070#post4070
TODO: Make the new 'Search' button functional.

------------------------------------------------------------------------
(11:39:34 PM) Matt`SS: Weird
(11:40:06 PM) Matt`SS: Do add that to open.ss.com as a new ticket assigned to me if you notice it
(11:40:15 PM) elijahlofgren: no worries though. Doesn't bother me now that I know about it. I've just posted screenshots showing new stuff I've done: http://www.silverstripe.com/silverstripe-development/flat/3799?showPost=4077#post4077
(11:40:16 PM) Matt`SS: username mpeel :)
(11:40:22 PM) elijahs-supybot: Title: SilverStripe Development (at www.silverstripe.com)
Start Stop Elapsed
08/15/2007 11:05:47 PM   11:42:12 PM 00:36:25
  10:35:00 PM   10:45:00 PM 00:10:00
  10:20:17 PM   10:28:29 PM 00:08:12
  04:45:54 PM   05:20:22 PM 00:34:28
  03:33:08 PM   04:04:57 PM 00:31:49
  01:45:41 PM   03:29:55 PM 01:44:14
  01:16:58 PM   01:34:49 PM 00:17:51
  11:32:00 AM   12:44:22 PM 01:12:22
  11:18:00 AM   11:24:00 AM 00:06:00
  10:31:10 AM   10:56:58 AM 00:25:48


Reading/updating forums/trac/wiki/blog/IRC
(08:01:05 AM) mujma: Do you get "Fatal error: Cannot redeclare Permission::$strict_checking..." after update ?
(08:38:29 AM) elijahlofgren: mujma: I'll see if I get it.
(08:50:32 AM) elijahlofgren: This looks nice! r40121 | aoneil | 2007-08-15 01:09:00 -0500 (Wed, 15 Aug 2007) | 1 line Updated data model to get new record IDs from MySQL, like a grown-up application should (merged from 2.0 branch, r37846)
(08:53:15 AM) elijahlofgren: mujma: I'm getting the same error now. I'll take a look at it.
(08:54:03 AM) elijahlofgren: (08:53:15 AM) elijahlofgren: mujma: I'm getting the same error now. I'll take a look at it.
(08:57:21 AM) CIA-34: Silverstripe-elijah: elijahlofgren * rdf46e6ae7b7b /security/Permission.php: BUGFIX: Fix 'Fatal error: Cannot redeclare Permission::$strict_checking...' error
(08:59:25 AM) mujma: Unfortunately there is more errors :(
(08:59:27 AM) elijahlofgren: I'm now getting this error: FATAL ERROR: DATABASE ERROR: Couldn't run query: SELECT `Group_Members`.*, `Group`.*, `Group`.ID, if(`Group`.ClassName,`Group`.ClassName,'Group') AS RecordClassName FROM `Group` INNER JOIN `Group_Members` ON `Group_Members`.GroupID = `Group`.ID WHERE (`table`.MemberID = 1) GROUP BY `Group`.ID | Unknown column 'table.MemberID' in 'where clause'
(09:00:05 AM) mujma: me too
(09:00:22 AM) elijahlofgren: It seems that `table` should be the actual name of a table.. Hmm...
(09:03:05 AM) mujma: I have updated to r40075 and everything works ok
(09:04:39 AM) mujma: but head revision is r40171 :/
(09:13:56 AM) CIA-34: Silverstripe-elijah: elijahlofgren * rd1e12706f0fa /core/model/DataObject.php: BUGFIX: Add missing '$' before 'table' in DataObject->getManyManyComponents() to fix fatal database error.
(09:15:15 AM) elijahlofgren: mujma: svn up should fix it now. :)
(09:18:33 AM) mujma: could you check this pagination ?
(09:18:46 AM) mujma: for me it works ok
(09:18:59 AM) elijahlofgren: ah, it works well now. :) Great job! :)
(09:19:25 AM) elijahlofgren: I'll mark them as complete on the list and say you fixed them.
(09:20:00 AM) mujma: great :)
(09:25:20 AM) elijahlofgren: Marked as fixed http://www.elijahlofgren.com/silverstripe/usability-items-complete/#54 :)
(09:25:33 AM) elijahs-supybot: Title: Usability Items Complete (at www.elijahlofgren.com)
9:32pm Talking to Bernat about http://support.silverstripe.com/gsoc/ticket/71
9:48pm Reading new forum/trac/wiki updates
Start Stop Elapsed
08/15/2007 10:17:37 AM   10:24:15 AM 00:06:38
  10:06:30 AM   10:08:22 AM 00:01:52
  09:48:46 AM   09:57:54 AM 00:09:08
  09:32:17 AM   09:39:03 AM 00:06:46
  09:11:16 AM   09:29:37 AM 00:18:21
  08:39:15 AM   09:05:10 AM 00:25:55


Working on blogging progress report.
(09:36:32 PM) elijahlofgren: Progress update: http://www.elijahlofgren.com/soc/ Goodnight all! :)
(09:36:40 PM) elijahs-supybot: Title: Elijah s 2007 Google Summer of Code Experience (at www.elijahlofgren.com)
Start Stop Elapsed
08/14/2007 09:21:30 PM   09:30:39 PM 00:09:09


Working on ticket: #73 Rename 'Delete' button to 'Bulk Actions' and add 'Publish selected pages' button
(07:01:04 PM) ajoneil: hmm
(07:01:12 PM) ajoneil: i just switched to gsoc branch, and im getting errors...
(07:01:22 PM) elijahlofgren: refresh browser?
(07:01:32 PM) elijahlofgren: ?flush=1 (I just changed templates/js)
(07:01:59 PM) ajoneil: FATAL ERROR: DATABASE ERROR: Couldn't run query: SELECT ID FROM Permission WHERE (Code LIKE 'CMS_ACCESS_CMSMain' OR Code LIKE 'ADMIN') AND GroupID IN (2, 3) AND Enabled = 1 | Unknown column 'Enabled' in 'where clause'
(07:02:05 PM) ajoneil: seems to be member stuff
(07:02:11 PM) ajoneil: i did a db/build
(07:02:25 PM) elijahlofgren: Hmm.. I'll svn update and see if I can reproduce.
(07:03:06 PM) ajoneil: heh
(07:03:13 PM) ajoneil: its haydens merges from a few hours ago..
(07:05:27 PM) elijahlofgren: I also get: Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. in /var/www/silverstripe-gsoc-straight-svn/sapphire/security/Permission.php on line 257
(07:06:26 PM) ajoneil: hmm
(07:06:38 PM) ajoneil: well i found the changeset which that merge relied on
(07:06:41 PM) ajoneil: ill merge it in..
(07:06:49 PM) elijahlofgren: cool, thanks.
(07:12:26 PM) ***elijahlofgren learns that he needs to use: git-svn rebase instead of git-svn fetch in order to get new changes to be applied to his local git repo.
(07:14:13 PM) ajoneil: hmm, now i see why that code wasn't merged in :P
(07:16:57 PM) CIA-34: Silverstripe-elijah: elijahlofgren * rf1c58c2a2afa / (lang/en_US.php templates/Includes/CMSMain_left.ss):
(07:16:57 PM) CIA-34: Silverstripe-elijah: Rename 'Delete...' button to 'Batch Actions' in prep for implementing:
(07:16:57 PM) CIA-34: Silverstripe-elijah: http://support.silverstripe.com/gsoc/ticket/73 by adding a 'Publish
(07:16:57 PM) CIA-34: Silverstripe-elijah: selected pages' button.
(07:17:27 PM) elijahlofgren: ajoneil: why?
(07:21:21 PM) elijahlofgren: Matt`SS: welcome Matt.
(07:21:31 PM) ajoneil: because its to do with enabling/disabling permissions
(07:21:52 PM) ajoneil: and if you add it to a site then all its permissions are disabled..
(07:22:54 PM) ajoneil: ok well, i just removed the offending line
(07:28:38 PM) Matt`SS: Heya elijahlofgren
(07:28:45 PM) elijahlofgren: Matt`SS: howdy :)
(07:28:59 PM) Matt`SS: How's it going?
(07:29:22 PM) elijahlofgren: Matt`SS: I'm doing well. Yourself?
(07:30:01 PM) Matt`SS: Pretty good. Just got in to work from Uni
(07:30:18 PM) CIA-34: Silverstripe-elijah: elijahlofgren * r0c07b7858b3d /security/Permission.php:
(07:30:18 PM) CIA-34: Silverstripe-elijah: BUGFIX: Fix error: Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable
(07:30:19 PM) CIA-34: Silverstripe-elijah: call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file.
(07:31:33 PM) Matt`SS: Now I see what you're working on :)
(07:31:47 PM) elijahlofgren: CIA is great. :)
(07:32:08 PM) Matt`SS: Hehe yeah'
(07:33:43 PM) sarahk: elijah - got a link for cia?
(07:34:00 PM) elijahlofgren: sarahk: http://cia.vc/
(07:34:10 PM) elijahs-supybot: Title: CIA.vc (at cia.vc)
(07:34:53 PM) elijahlofgren: dude, I'm listed in the 'Most active projects today'! :) Silverstripe-elijah with 2 events. lol
(07:36:13 PM) elijahlofgren: Must be a slow day or something for most projects. :)
(07:37:15 PM) elijahlofgren: hmm.. Trying to edit a page gives a nice big SQL error along with "Table 'silverstripegsoc.Page' doesn't exist"
(07:37:51 PM) elijahlofgren: wait. Fixed.
(07:38:00 PM) elijahlofgren: Just need to run db/build?flush=1 again.
(07:44:40 PM) CIA-34: Silverstripe-elijah: elijahlofgren * r3abbd004fa5d / (lang/en_US.php templates/Includes/CMSMain_left.ss):
(07:44:41 PM) CIA-34: Silverstripe-elijah: Re-label 'Delete...' button as 'Batch Actions...' in prep for adding
(07:44:41 PM) CIA-34: Silverstripe-elijah: 'Publish the selected pages' button above the 'Delete the selected
(07:44:41 PM) CIA-34: Silverstripe-elijah: pages' one.
(07:45:36 PM) Matt`SS: haha, nice :)
(07:45:57 PM) Matt`SS: We should probably fix that 'table not found error'
(07:46:04 PM) Matt`SS: Although, you're running in dev mode right?
(07:46:15 PM) elijahlofgren: yes, Works fine for me know.
(07:46:48 PM) elijahlofgren: db/build fixed it. Might have had something to do with bug Andy just fixed.
(07:48:08 PM) elijahlofgren: hm.. 'Bulk Edit' or 'Batch Edit' would take up less space than 'Batch Actions'. Is either of those better labels?
8:00pm Testing out Majuma's Usability Fixes.
8:02pm Taking screenshot of problem and emailing it to Majuma.
8:08pm Back to working on this ticket.
(08:09:35 PM) Matt`SS: What for?
(08:09:47 PM) Matt`SS: Like, in what sections?
(08:09:56 PM) elijahlofgren: Left site frame: http://www.silverstripe.com/google-summer-of-code-forum/flat/1636?showPost=1859#post1859
(08:10:05 PM) elijahs-supybot: Title: Google Summer of Code (at www.silverstripe.com)
(08:10:26 PM) elijahlofgren: I'll hopefully be adding a "Search" button to replace the "Reorder..." one that is now a checkbox.
(08:10:29 PM) Matt`SS: ahh
(08:11:46 PM) Matt`SS: Hmm
(08:12:08 PM) Matt`SS: It's not really editing at all
(08:12:19 PM) Matt`SS: It's not batch edit - it's batch delete/publish etc
(08:12:38 PM) elijahlofgren: yeah, I guess "Actions" is better.
(08:13:01 PM) elijahlofgren: or maybe "Delete/Publish"
(08:13:15 PM) elijahlofgren: but then if we add another button.. ;)
(08:13:20 PM) Matt`SS: Yeah
(08:15:49 PM) ajoneil: elijahlofgren: im doing some merging into gsoc, let me know if things start to break ok?
(08:16:50 PM) elijahlofgren: If I remove the "..." from the "Create...", "Search...", and "Batch Actions..." buttons, they all fit on one line. I guess I'll remove them if nobody objects (ellipses are nice though.)
(08:17:18 PM) elijahlofgren: ajoneil: ok, I will.
(08:18:20 PM) elijahlofgren: (08:16:50 PM) elijahlofgren: If I remove the "..." from the "Create...", "Search...", and "Batch Actions..." buttons, they all fit on one line. I guess I'll remove them if nobody objects (ellipses are nice though.)
(08:18:20 PM) elijahlofgren: (08:17:18 PM) elijahlofgren: ajoneil: ok, I will.
(08:18:29 PM) ajoneil: :)
(08:18:32 PM) elijahlofgren: seems I got disconnected. ;)
(08:19:20 PM) Matt`SS: lunchtime for me now
(08:19:31 PM) elijahlofgren: Matt`SS: have a good one.
(08:32:53 PM) CIA-34: silverstripe: wrossiter * r40032 /open/modules/cms/trunk/templates/PageCommentInterface.ss:
(09:04:14 PM) Matt`SS: back
(09:04:26 PM) elijahlofgren: welcome back :)
(09:07:23 PM) xeraa: bye guys - i'm off to bed now. it's way too late already ;)
(09:07:34 PM) elijahlofgren: xeraa: have a good night!
(09:07:39 PM) ***elijahlofgren should go to bed soon also.
(09:08:42 PM) xeraa: thx and have a good night too
9:20pm http://support.silverstripe.com/gsoc/ticket/73
Changed 28 seconds ago by elofgren
* attachment Initial-Progress-on-gsoc-ticket-73-Publish-selected-pages-2007-08-14-2118.diff added
Initial Progress on adding "Publish Selected Pages" button.
Start Stop Elapsed
08/14/2007 08:42:00 PM   09:21:30 PM 00:39:30
  07:01:46 PM   08:36:58 PM 01:35:12


Working on spec: "Rework the way we create pages in Site Content"
2:56pm See here: http://www.silverstripe.com/google-summer-of-code-forum/flat/1636?showPost=1859#post1859
2:57pm Working on replacing the “Reorder…” button with a “Allow drag and drop page reordering” checkbox
(03:19:04 PM) CIA-34: Silverstripe-elijah: elijahlofgren * rb4b75f95a786 /core/i18n.php:
(03:19:04 PM) CIA-34: Silverstripe-elijah: Only search for text in folder with a _config.php file (which means they
5:45pm Pausing time and reading family blogs while ZoneAlarm installs on my WinXP Vmware (need to test changes in IE7 once it finishes).
(03:19:04 PM) CIA-34: Silverstripe-elijah: are modules) and Make sure the templates directory exists before trying
(03:19:04 PM) CIA-34: Silverstripe-elijah: to open it in order to fix ticket: 'i18n: text_collector should only
(03:19:04 PM) CIA-34: Silverstripe-elijah: look in directories that have a _config.php and make sure template dirs
(03:19:06 PM) CIA-34: Silverstripe-elijah: exist before opening them' http://support.silverstripe.com/gsoc/ticket/71
(03:27:22 PM) mujma: Anyone has idea how to iterate over a array in template ?
(03:27:43 PM) elijahlofgren: I think I've done something similar I'll pull up some code in a minute...
(03:29:00 PM) elijahlofgren: mujma: I posted a short example here: http://doc.silverstripe.com/doku.php?id=arrayData
(03:29:12 PM) elijahs-supybot: Title: arraydata [SilverStripe Documentation] (at doc.silverstripe.com)
(03:35:51 PM) mujma: works :D thanks elijah
(03:42:39 PM) elijahlofgren: mujma: you're welcome. :)
(04:13:40 PM) CIA-34: Silverstripe-elijah: elijahlofgren * r2b38c2c974b4 / (3 files in 3 dirs):
(04:13:40 PM) CIA-34: Silverstripe-elijah: Replace the 'Reorder...' button with a 'Allow
(04:13:40 PM) CIA-34: Silverstripe-elijah: drag & drop reordering' checkbox as per:
(04:13:40 PM) CIA-34: Silverstripe-elijah: http://www.silverstripe.com/google-summer-of-code-forum/flat/1636?showPost=1859#post1859
(04:13:46 PM) elijahs-supybot: Title: Google Summer of Code (at www.silverstripe.com)
4:13pm Testing in IE6, IE7, and Safari 3.
(04:31:26 PM) ajoneil: morning!
(04:31:34 PM) elijahlofgren: ajoneil: good morning! :)
(04:38:53 PM) ***elijahlofgren uninstalls Filseclab firewall because of BSOD issues and tries Zone Alarm Free (after avoiding it because it sounded bloated)
(04:39:06 PM) elijahlofgren: halkyon: welcome Sean :)
(04:39:29 PM) ajoneil: halkyon: high five!!
(04:45:13 PM) halkyon: hey guys :)
(04:56:11 PM) elijahlofgren: ajoneil: Mind taking a look at: http://support.silverstripe.com/gsoc/ticket/59 ? The "Insert Link" in TinyMCE seems to work fine for me in FF 2.
(05:11:41 PM) halkyon: Zone Alarm... is that still bloated?
(05:12:26 PM) halkyon: all I remember is my flatmate always complained to me about something not working, then I just 'turn off the firewall' and it would always work :-)
(05:12:34 PM) elijahlofgren: I don't know. I hope not. :)
(05:12:50 PM) elijahlofgren: indeed. I've tried like 3 firewalls for my sister's PC's recently.
(05:16:19 PM) ajoneil: hmm
(05:16:39 PM) ajoneil: does anyone have any idea why the latest posts rss feed keeps going down?
(05:17:29 PM) elijahlofgren: ajoneil: I think Markus made a patch for that recently. Encoding of HTML or something I think.
(05:17:30 PM) sarahk: Hi guys - quick question... in main.php we hardcode the server encoding with
(05:17:30 PM) sarahk: header("Content-type: text/html; charset=\"utf-8\"");
(05:18:02 PM) sarahk: I'd rather change the encoding on my server than to have a system file I have to patch with every upgrade
(05:18:05 PM) sarahk: how do I change it on my server?
(05:18:20 PM) sarahk: or is it really the server and will affect all accounts on a shared host?
(05:19:13 PM) ajoneil: elijahlofgren: really, do you have a link?
(05:20:17 PM) elijahlofgren: ajoneil: Here you go: http://support.silverstripe.com/gsoc/changeset/39702 (I get a forbidden error though)
(05:20:39 PM) elijahlofgren: r39702 | mlanthaler | Bugfix: Since title was not escaped right, the RSS feed is invalid if there is an tag like in the title of an entry.
(05:20:53 PM) elijahlofgren: sarahk: I don't know. Sorry.
(05:21:24 PM) sarahk: I'll dig around... think I may have a change request for the silverstripe guys - to allow the encoding to be a config setting
(05:22:06 PM) ajoneil: elijahlofgren: that fixes it when its invalid, but sometimes the RSS feed just doesn't work at all
(05:22:11 PM) ajoneil: like now for example.
(05:24:13 PM) elijahlofgren: seems to be working ok here: http://www.silverstripe.com/silverstripe-forum/rss but I don't know why it doesn't always work.
(05:24:20 PM) ajoneil: yeah it is working now..
(05:24:22 PM) ajoneil: hmm...
05:26:27 PM) sarahk: I've asked here: http://forums.digitalpoint.com/showthread.php?t=437799
(05:26:33 PM) elijahs-supybot: Title: Changing server encoding (at forums.digitalpoint.com)
(05:26:51 PM) sarahk: fwiw - I set the feed up using the info on the silverstripe forum and had no problems. h
(05:27:01 PM) sarahk: those i did have I documented in the forum
(05:27:08 PM) sarahk: runs a treat - just doesn't validate
(05:28:01 PM) sarahk: the silverstripe version fails validation too :) http://feedvalidator.org/check.cgi?url=http%3A%2F%2Fwww.silverstripe.com%2Fsilverstripe-forum%2Frss
(05:28:12 PM) sarahk: on the guid bit - and that's deep in the parser
(05:28:13 PM) elijahs-supybot: Title: Feed Validator Results: http://www.silverstripe.com/silverstripe-forum/rss (at feedvalidator.org)
(05:28:25 PM) sarahk: supybot is cute
(05:28:29 PM) sarahk: off now, will check in later
(05:35:18 PM) ***elijahlofgren finishes configuring ZoneAlarm on his sister's PC. Seems like a nice program. Installing on my VmWare XP install now.
(05:52:54 PM) CIA-34: silverstripe: aoneil * r40008 /open/modules/forum/trunk/code/Post.php: Parse bbcode in rss feed
(05:55:09 PM) ajoneil: yay for CIA
(05:55:19 PM) ajoneil: and yay for >r40000 :)
(05:55:27 PM) elijahlofgren: indeed! Congrats. :)
(05:58:19 PM) ***elijahlofgren goes to eat supper (as WinXP reboots after finally getting ZoneAlarm installed)
(06:26:33 PM) ***elijahlofgren comes back from supper
(06:32:39 PM) elijahlofgren: thanks :) Trying to get ZoneAlarm configured so I can get back to testing new "Allow drag & drop reordering" checkbox in IE7 (replaces "Reorder..." button)
(06:36:18 PM) elijahlofgren: aha! FF2 is too forgiving of extra "," in an array. Thanks to Microsoft Script Editor, it wasn't too hard to find the problem in IE7. :)
(06:40:22 PM) elijahlofgren: hmm.. Seems FF2 was too forgiving of missing tag too. Good thing I test in IE7 I guess. ;)
(06:41:53 PM) CIA-34: Silverstripe-elijah: elijahlofgren * r59c1f879f141 / (2 files in 2 dirs): Remove trailing ',' and missing causing errors in IE7.
(06:43:32 PM) ajoneil: thanks CIA! :)
(06:44:16 PM) elijahlofgren: CIA is so cool. I doubt I'll ever want to work on an open source project without it.
(06:45:54 PM) ajoneil: hehe
(06:45:57 PM) ajoneil: ohloh is cool too :D
(06:46:02 PM) ajoneil: i see you signed up :)
(06:46:20 PM) elijahlofgren: yeah, only could list CMSMS though, since gsoc branch isn't public yet. ;)
(06:46:46 PM) ajoneil: true
6:56pm:
------------------------------------------------------------------------
r40009 | elofgren | 2007-08-14 18:54:40 -0500 (Tue, 14 Aug 2007) | 3 lines

Replace the 'Reorder...' button with a 'Allow drag & drop reordering' checkbox as per:
http://www.silverstripe.com/google-summer-of-code-forum/flat/1636?showPost=1859#post1859

------------------------------------------------------------------------
Start Stop Elapsed
08/14/2007 06:49:05 PM   07:01:46 PM 00:12:41
  06:33:56 PM   06:47:57 PM 00:14:01
  03:53:51 PM   04:30:49 PM 00:36:58
  02:56:32 PM   03:34:30 PM 00:37:58


Reading new forum/wiki/trac/svn updates
2:43pm This is great!!! http://www.silverstripe.com/general-discussion/show/3967?showPost=3990
http://doc.silverstripe.com/doku.php?id=customising-content-in-your-templates
Start Stop Elapsed
08/14/2007 02:40:45 PM   02:56:32 PM 00:15:47


Updating Usability To Do list with issues that Mateusz has fixed
2:32pm Also fixed issue with git-svn not fetching new revisions.
Start Stop Elapsed
08/14/2007 02:20:30 PM   02:32:50 PM 00:12:20
  01:56:50 PM   02:15:00 PM 00:18:10


Confirming that: Ticket #40 Find source of PHP cookie bug is indeed fixed
1:43pm Indeed, this is fixed. Closing.
Start Stop Elapsed
08/14/2007 01:42:58 PM   01:46:27 PM 00:03:29


Reading/Posting new forum/wiki/trac updates & working on Ticket #35
Replying to http://www.silverstripe.com/general-discussion/flat/3918
9:17pm Replied: http://www.silverstripe.com/general-discussion/flat/3918?showPost=3948#post3948
9:18pm Reading: http://doc.silverstripe.com/doku.php?id=many_many-example
9:25pm Looking at http://support.silverstripe.com/gsoc/ticket/35 "Page name and Navigation label improvements"
(10:01:46 PM) elijahlofgren: yikes, It seems having duplicate Behaviour.register calls (on same element) makes neither get called?!? Not good I tihnk.. ;)
(10:02:06 PM) elijahlofgren: *think
(10:25:02 PM) ajoneil: yeah doesnt sound good
(10:25:05 PM) ajoneil: hello btw! :)
(10:25:55 PM) elijahlofgren: Thanks :) I'm just going to plop I my code in the other behaviour.register call for now and leave @todo note. I need to go to bed soon ;)
(10:26:24 PM) ajoneil: fair nuff!
(10:43:25 PM) elijahlofgren: Filed ticket: http://open.silverstripe.com/ticket/1415
(10:46:38 PM) CIA-34: Silverstripe-elijah: elijahlofgren sapphire-gsoc * rbdf3a8f5da52 /javascript/UpdateURL.js:
(10:46:39 PM) CIA-34: Silverstripe-elijah: Fix Trac Ticket: 'Page name and Navigation label improvements'
(10:46:39 PM) CIA-34: Silverstripe-elijah: http://support.silverstripe.com/gsoc/ticket/35 by making it so that
(10:46:39 PM) CIA-34: Silverstripe-elijah: 'If you type in Page name, the Navigation Label and Meta Title should
(10:46:39 PM) CIA-34: Silverstripe-elijah: automatically update the first time'
(11:07:34 PM) elijahlofgren: Progress update: http://www.elijahlofgren.com/soc/ Goodnight all! :)
Start Stop Elapsed
08/13/2007 09:41:45 PM   11:03:38 PM 01:21:53
  09:28:32 PM   09:32:46 PM 00:04:14
  09:23:21 PM   09:26:38 PM 00:03:17
  09:03:27 PM   09:21:19 PM 00:17:52
  08:50:49 PM   09:01:56 PM 00:11:07


Commenting on ticket: Ticket #40 Find source of PHP cookie bug
Updated: http://support.silverstripe.com/gsoc/ticket/40#comment:9
Start Stop Elapsed
08/13/2007 11:42:12 AM   11:47:18 AM 00:05:06


Working on: Ticket #35 Page name and Navigation label improvements
(04:26:32 PM) CIA-34: Silverstripe-elijah: elijahlofgren cms-gsoc * r3fe2dbceb919 /css/cms_right.css:
(04:26:33 PM) CIA-34: Silverstripe-elijah: Make form input fields width: 96%; like textareas already are as part
(04:26:33 PM) CIA-34: Silverstripe-elijah: of fix for: http://support.silverstripe.com/gsoc/ticket/35
(04:40:29 PM) CIA-34: Silverstripe-elijah: elijahlofgren cms-gsoc * r674a9c84158c /code/NewsletterAdmin.php: Apply NewsletterAdmin bugfixes from gsoc SVN: r39865 r39864 and r39863
(04:43:48 PM) CIA-34: Silverstripe-elijah: Make 'Add new draft' the default action for 'Create...' in the Newsletter
(04:43:48 PM) CIA-34: Silverstripe-elijah: section. as done in SVN r39865
(04:45:46 PM) CIA-34: Silverstripe-elijah: Apply NewsletterAdmin bugfixes from gsoc SVN: r39865 r39864 and r39863
(04:45:46 PM) CIA-34: Silverstripe-elijah: to cms/javascript (Note to self: git-svn fetch does not fetch files
(04:45:46 PM) CIA-34: Silverstripe-elijah: you delete.)
Start Stop Elapsed
08/11/2007 04:21:10 PM   04:45:57 PM 00:24:47
  03:52:00 PM   04:00:00 PM 00:08:00


Working on Ticket: #70 Change the Newsletter Create drop-down to 'Add new draft' once something is selected in the left frame
(05:54:19 PM) CIA-34: Silverstripe-elijah: elijahlofgren cms-gsoc * r76f7c3303ed5 /javascript/NewsletterAdmin_left.js:
(05:54:19 PM) CIA-34: Silverstripe-elijah: Found way to detect when 'Create...' button is clicked in Newsletter
(05:54:19 PM) CIA-34: Silverstripe-elijah: section. Working on 'Change the Newsletter Create drop-down to
(05:54:19 PM) CIA-34: Silverstripe-elijah: 'Add new draft' once something is selected in the left frame'
(05:54:20 PM) CIA-34: Silverstripe-elijah: http://support.silverstripe.com/gsoc/ticket/70
(06:00:05 PM) CIA-34: Silverstripe-elijah: elijahlofgren cms-gsoc * rb485d6535035 /javascript/NewsletterAdmin_left.js:
(06:00:05 PM) CIA-34: Silverstripe-elijah: Found way to detect when 'Create...Almost found way to detect if something
(06:00:05 PM) CIA-34: Silverstripe-elijah: is selected in left site tree.
(06:00:14 PM) ***elijahlofgren goes to eat supper and watch a 3 hour movie with his sisters.
9:26pm Reading forum/blog/doc updates.
9:32pm Back to work on this ticket.
------------------------------------------------------------------------
r39863 | elofgren | 2007-08-10 21:53:33 -0500 (Fri, 10 Aug 2007) | 1 line

BUGFIX: If no selection is made in the left tree, and a draft is added, parentID won't be set, so don't rely on it being set in Javascript and instead add a hidden ParentID field that is returned by PHP and use that so it is alway set correctly. This solves a bug where Newsletter drafts will be added, but not show up in the left tree (because of a Javascript error), if no selection has been made.
------------------------------------------------------------------------
------------------------------------------------------------------------
r39865 | elofgren | 2007-08-10 23:04:32 -0500 (Fri, 10 Aug 2007) | 1 line

USABILITY: Make 'Add new draft' the default action for 'Create...' in the Newsletter section. Also make 'Add new draft' be selected whenever a selection is made in the left tree. Only select 'Add new type' by default if there are no Newsletter types. This will reduce confusion and make the more common 'Add new draft' action easier since it will be the default. Also select the 'Add new draft' option after a Newsletter type is added since this will be the next logical action. This fixes GSoC trac ticket: http://support.silverstripe.com/gsoc/ticket/70
------------------------------------------------------------------------
r39864 | elofgren | 2007-08-10 22:30:58 -0500 (Fri, 10 Aug 2007) | 1 line

BUGFIX: If there are no Newsletter types, and 'Add new draft' is chosen, create a Newsletter type to prevent errors. This makes either drop-down option work.
------------------------------------------------------------------------
(11:09:41 PM) elijahlofgren: Yay, Newsletter section work is now complete. :)
Start Stop Elapsed
08/10/2007 09:26:35 PM   11:11:11 PM 01:44:36
  05:39:39 PM   06:00:23 PM 00:20:44


Reading/Replying to New SilverStripe updates (forum,wiki,trac,SVN) & Working on Newsletter System Improvements
2:17pm Seeing if I can reproduce: http://open.silverstripe.com/ticket/1411
2:24pm Ah, "Filter" button is on second line
2:26pm Ah, Empty label element. Maybe this will take 1 minute to fix. Er.. not long. ;)
(02:31:24 PM) xeraa: bye everyone - have a nice week-end :-)
(02:31:38 PM) elijahlofgren: xeraa: you too! :)
(02:31:53 PM) xeraa: thanks!
2:57pm Fixed http://open.silverstripe.com/ticket/1411
Changed 1 minute ago by elijahlofgren ¶

I've fixed this for the security section in the gsoc branch of sapphire:

r39858 | elofgren | 2007-08-10 14:54:41 -0500 (Fri, 10 Aug 2007) | 3 lines

BUGFIX: Fix trac ticket: #1411 'Layout problems with search box in IE' http://open.silverstripe.com/ticket/1411 by only creating a 'label' tag if a 'Title' is set in FormField?->FieldHolder?()

I assume it's also fixed for the "feedback" section, but I don't know where or what that section is. ;)
Changed 12 seconds ago by elijahlofgren

* attachment silverstripe-elijah.git-1a8a07d415e124de525053bd2f7c7c0857f1cb7b.patch added

Patch to fix ticket #1411 by only creating a label tag if a Title is set.
3:04pm Going to update http://support.silverstripe.com/gsoc/wiki/GSoc07UsabilityElijah stating I've finished Newsletter stuff, then update http://open.silverstripe.com/ticket/792 with a link to the wiki page.
3:23pm Hmm.. Need to make sure that bounces get auto-blacklisted....
3:26pm TODO: I've implemented "Bounces report with tickboxes ticked by default (to not send to in the future, unticking resends)" wrong. I need to black it blacklist by default and change "Uncheck the box to disable sending to an email address." to "Uncheck the box to enable sending to an email address. and add a Blacklisted column heading."
(03:41:06 PM) CIA-34: Silverstripe-elijah: elijahlofgren cms-gsoc * rcecd300a832f /templates/Includes/NewsletterAdmin_BouncedList.ss:
(03:41:06 PM) CIA-34: Silverstripe-elijah: On Newsletter 'Mailing List' 'Bounced' tab: Change instructions from "Uncheck the box to *disable* sending to an email
(03:41:07 PM) CIA-34: Silverstripe-elijah: address." to "Uncheck the box to *enable* sending to a blacklisted email
(03:41:07 PM) CIA-34: Silverstripe-elijah: address.", label checkbox column as Blacklisted, and show the checkbox
(03:41:09 PM) CIA-34: Silverstripe-elijah: checked if Member.BlacklistedEmail is true. This makes things easier to
(03:41:11 PM) CIA-34: Silverstripe-elijah: understand and correctly complies with "Bounces report with tickboxes
(03:41:13 PM) CIA-34: Silverstripe-elijah: ticked by default (to not send to in the future, unticking resends)" spec.
(03:58:36 PM) CIA-34: Silverstripe-elijah: elijahlofgren cms-gsoc * r765170f8d06d /templates/Includes/NewsletterAdmin_BouncedList.ss:
(03:58:36 PM) CIA-34: Silverstripe-elijah: On Newsletter Mailing List Bounced tab: Change 'Last bounce at' column
(03:58:36 PM) CIA-34: Silverstripe-elijah: label to 'Date' to be more accurate because multiple bounce records will
(03:58:36 PM) CIA-34: Silverstripe-elijah: be shown for a member if their email has bounced more than once.
4:25pm Commits to sapphire:
------------------------------------------------------------------------
r39860 | elofgren | 2007-08-10 16:25:26 -0500 (Fri, 10 Aug 2007) | 2 lines

*Blacklist bounced newsletter recipient emails by default* in order to comply with spec: 'Bounces report with tickboxes ticked by default (to not send to in the future, unticking resends)'

------------------------------------------------------------------------
r39859 | elofgren | 2007-08-10 16:24:36 -0500 (Fri, 10 Aug 2007) | 2 lines

Add: 'Note: This does not seem to be used anywhere.' next to 'Bounced' => 'Boolean' Member 'db' definition.

------------------------------------------------------------------------
4:33pm Commits to cms:
------------------------------------------------------------------------
r39862 | elofgren | 2007-08-10 16:33:38 -0500 (Fri, 10 Aug 2007) | 3 lines

On Newsletter Mailing List Bounced tab: Change 'Last bounce at' column label to 'Date' to be more accurate because multiple bounce records will be shown for a member if their email has bounced
more than once.

------------------------------------------------------------------------
r39861 | elofgren | 2007-08-10 16:32:53 -0500 (Fri, 10 Aug 2007) | 4 lines

On Newsletter 'Mailing List' 'Bounced' tab: Change instructions from "Uncheck the box to *disable* sending to an email address." to "Uncheck the box to *enable* sending to a *blacklisted* email
address.", label checkbox column as Blacklisted, and show the checkbox checked if Member.BlacklistedEmail is true. This makes things easier to understand and correctly complies with spec:
"Bounces report with tickboxes ticked by default (to not send to in the future, unticking resends)"

------------------------------------------------------------------------
4:43pm I just got logged out of the admin again. With alc_enc cookie set to 1%3Aec90a15fce66205e25f164caa6947c36 going to run debug files on:
4:53pm Posted comment: http://support.silverstripe.com/gsoc/ticket/40#comment:7
5:03pm Posted update to "Ticket #792 Newsletter system should model SS1's more closely": http://open.silverstripe.com/ticket/792#comment:2
5:21pm Updated: http://doc.silverstripe.com/doku.php?id=email_bouncehandler
5:30pm Filed:
"Exim ping script needs to be updated to send X-SilverStripeMessageID header & EMAIL_BOUNCEHANDLER_KEY to Email_BounceHandler"
http://support.silverstripe.com/gsoc/ticket/68
"UPGRADING file needs notes about 2 new parameters required by Email_BounceHandler in SS 2.1"
http://support.silverstripe.com/gsoc/ticket/69
5:34pm Updated: http://support.silverstripe.com/gsoc/wiki/GSoc07UsabilityElijah
Start Stop Elapsed
08/10/2007 02:10:01 PM   05:39:39 PM 03:29:38


Working on Tickets: #56 After Newsletter type is deleted, it should not still be editable in right frame & Ticket #66 Error when "Restore" button is clicked after a page is "Removed from the draft site"
3:02pm http://support.silverstripe.com/gsoc/ticket/56
3:03pm Found a new bug that I think I caused, filing a ticket about it.
3:04pm Filed: http://support.silverstripe.com/gsoc/ticket/66 "Error when "Restore" button is clicked after a page is "Removed from the draft site""
3:20pm Working on fixing above new ticket.
(03:27:51 PM) CIA-34: Silverstripe-elijah: elijahlofgren cms-gsoc * rde509eb4f2b4 /javascript/CMSMain_right.js:
(03:27:51 PM) CIA-34: Silverstripe-elijah: BUGFIX: Fix trac ticket: #66 Error when "Restore" button is clicked after a
(03:27:51 PM) CIA-34: Silverstripe-elijah: page is "Removed from the draft site"
(03:27:51 PM) CIA-34: Silverstripe-elijah: http://support.silverstripe.com/gsoc/ticket/66
3:28pm Need to make "Unpublish" button have AJAXy loading icon. Working on that.
(03:38:10 PM) ***elijahlofgren tries to find where "Unpublishing..." text is coming from. Trying to add AJAXy loading icon to "Unpublish" icon. Not finding it with grep.
3:57pm Filed new ticket: http://support.silverstripe.com/gsoc/ticket/67 Ticket #67: Add AJAXY loading icon when "Unpublish" button is clicked on a page.
4:00pm Need to update: http://open.silverstripe.com/ticket/792 with link to http://support.silverstripe.com/gsoc/wiki/GSoc07UsabilityElijah after I update that.
(04:02:52 PM) Matt`SS: hehe
(04:02:57 PM) Matt`SS: You won't find it :P
(04:03:29 PM) elijahlofgren: It's strange. Stuff like "Saving..." is there. This must be done differently or something.
(04:03:31 PM) Matt`SS: I think there's still a javascript method which just adds "ing..." to the end of any of those form actions when you're clicked :P
(04:03:44 PM) elijahlofgren: Ah, I should look for that method. :)
(04:03:51 PM) Matt`SS: Might be called verbalize or something? Not sure what it's called
(04:04:07 PM) elijahlofgren: ok, thanks. I'll do some looking.
(04:06:35 PM) ajoneil: mornin'
(04:06:59 PM) elijahlofgren: good morning :)
(04:08:30 PM) Matt`SS: Morning friend! :]
(04:08:39 PM) ajoneil: :-)
(04:12:17 PM) CIA-34: Silverstripe-elijah: elijahlofgren cms-gsoc * r1041eb8298c6 /code/NewsletterAdmin.php:
(04:12:17 PM) CIA-34: Silverstripe-elijah: BUGFIX: Fix Ticket: #56 After Newsletter type is deleted, it should not
(04:12:17 PM) CIA-34: Silverstripe-elijah: still be editable in right frame
(04:12:17 PM) CIA-34: Silverstripe-elijah: http://support.silverstripe.com/gsoc/ticket/56
(04:24:54 PM) ajoneil: yay CIA
4:35pm Filing a new bug report.
4:43pm New bug filed: http://open.silverstripe.com/ticket/1409
Start Stop Elapsed
08/09/2007 04:27:25 PM   04:44:18 PM 00:16:53
  03:21:25 PM   04:23:08 PM 01:01:43
  03:01:36 PM   03:10:34 PM 00:08:58


Reading new forum posts / svn commits / wiki changes / trac tickets
2:21pm Going to try sharethis module: http://svn.silverstripe.com/open/modules/sharethis/trunk/
2:37pm Told Laktek about 2 minor issues I found: http://www.silverstripe.com/google-summer-of-code-forum/flat/2151?showPost=3788
2:37pm Back to reading new forum posts.
Start Stop Elapsed
08/09/2007 02:35:40 PM   03:01:36 PM 00:25:56
  02:11:37 PM   02:33:48 PM 00:22:11


Preparing Status report post
Start Stop Elapsed
08/08/2007 10:45:25 PM   10:50:46 PM 00:05:21
  10:40:30 PM   10:43:04 PM 00:02:34


Working on ticket: #1370 Behaviour is not applied with ajax in IE & other tickets and bugs & helping in #silverstripe
2:00pm Verifying that it is still broken in IE6 & IE7.
2:01pm WinXP in VMware is running quite slow as AVG updates and NetVeda Safety.net firewall runs.
2:04pm Still problem: On IE7, I get this when clicking "Mailing List":
A Runtime Error has occured. Do you wish to Debug? Line: 1574 Error: Object required.
Clicking yes..
2:05pm PC swaps as it runs Kubuntu, WinXP, Apache2, FF2, IE6, IE7, and Safari 3 at same time. ;)
2:06pm After enabling script error notifications in IE6, I get this error after clicking "Mailing List": Line: 1575 Error: Object required.
2:08pm Microsoft Script Editor comes up...
2:09pm This is the error line:
if (tinyMCE.isRealIE && window.event.type == "readystatechange" && document.readyState != "complete")
2:10pm Uh oh. That line shouldn't be here:
if (tinyMCE.isRealIE && window.event.type == "readystatechange" && document.readyState != "complete")
if (tinyMCE.isRealIE && window.event && window.event.type == "readystatechange" && document.readyState != "complete")
return true;
2:10pm Seems I maybe git/svn merged wrong. Checking...
2:15pm elijahlofgren@kubuntu:/var/www/silverstripe-gsoc/jsparty/tiny_mce2-straight-svn$ svn up && svn diff --revision 39708:39709
(14:16:36) elijahlofgren: bfcapell: welcome Bernat. :)
(14:17:04) bfcapell: hi elijah and everybody :)
(14:17:21) elijahlofgren: what are you working on today? I'm working on: http://open.silverstripe.com/ticket/1370
(14:17:29) elijahs-supybot: Title: #1370 (Behaviour is not applied with ajax in IE) – SilverStripe Open Source Trac – Trac (at open.silverstripe.com)
(14:18:40) bfcapell: oh yes ie it's a pain :)
(14:18:47) bfcapell: i was also resolving some issues yesterday
(14:19:20) bfcapell: right now i'm working in a form to upload module language files to be translated
(14:19:49) elijahlofgren: cool
2:21pm: elijahlofgren@kubuntu:~/www/silverstripe-gsoc/jsparty/tiny_mce2$ sudo apt-get install cogito
2:23pm Trying: http://dev.gentoo.org/~ferdy/stuff/ciabot.bash
2:34pm Pausing timer while I try to get email for CIA working.
2:54pm Set up a forwarder because I kept getting stuff like this in my postfix log:
Aug 8 14:39:51 kubuntu postfix/smtp[32106]: BEE7C268EEF: to=, relay=aspmx.l.google.com[72.14.253.27]:25, delay=19, delays=0.03/0.01/14/5.3, dsn=5.1.1, status=bounced (host aspmx.l.google.com[72.14.253.27] said: 550 5.1.1 No such user y11si1707983pod (in reply to RCPT TO command))
2:57pm Ok, that doesn't seem to work. Trying http://git.kernel.org/?p=cogito/cogito.git;a=blob;hb=HEAD;f=contrib/ciabot.pl with Cogito.
3:18pm cogito-0.18.2 calls commit-post! ciabot.pl is *ONLY* made to work with Cogito, *NOT* plain git! "-# $GIT_DIR/hooks/commit-post:: +# $GIT_DIR/hooks/post-commit:: (legacy: commit-post)" http://www.gelato.unsw.edu.au/archives/git/0610/29805.html
(15:15:50) CIA-34: Silverstripe-elijah: elijahlofgren tiny_mce2 * r2bd1bf2ff06e /tiny_mce_src.js: Revert to r39709 of SS SVN tiny_mce_src.js (finally got CIA working with
3:20pm Now back to real work. Fixing bug in IE! ;)
3:24pm Verfied "Mailing List" "Bounced" tabs works fine in Safari 3.
3:25pm Strange. Same error in IE. It's like it's using a cached version.
3:28pm Deleting IE7 Temporary Internet Files. Reloading page.
3:29pm Now no more TinyMCE errors, and It works!?!?! :) I think http://www.silverstripe.com/google-summer-of-code-forum/flat/3618 was the fix for http://open.silverstripe.com/ticket/1370 ! :)
3:31pm Hmm.. I need to change it to onclick instead of onchange because IE requires clicking and the having the checkbox lose focus before it calls onchange. But it works! :)
3:35pm Posted here: http://open.silverstripe.com/ticket/1370#comment:4
It seems that Markus's fix that Andy merged into TinyMCE in r39709 has fixed this bug for me! :) See: http://www.silverstripe.com/google-summer-of-code-forum/flat/3618
Andy, can you confirm that this issue is fixed?
3:42pm Confirmed that http://support.silverstripe.com/gsoc/ticket/63 "Checkboxes on Mailing List Bounced tab don't work & X delete links reloads whole page in IE6 or IE7" is now fixed! :) It was fixed by:
------------------------------------------------------------------------
r39709 | aoneil | 2007-08-07 16:33:11 -0500 (Tue, 07 Aug 2007) | 2 lines

Fix tinymce in IE - http://www.silverstripe.com/google-summer-of-code-forum/flat/3618

------------------------------------------------------------------------
3:46pm: (15:46:44) CIA-34: Silverstripe-elijah: elijahlofgren cms-gsoc * r4c3d87092c7f /javascript/NewsletterAdmin_right.js: Use onclick instead of onchange event so that blacklist add/removing is
------------------------------------------------------------------------
r39745 | elofgren | 2007-08-08 15:52:12 -0500 (Wed, 08 Aug 2007) | 1 line

Use onclick instead of onchange event so that blacklist add/removing is immediately called by IE when checkboxes are clicked on the 'Bounced' tab of the 'Mailing List' section of the 'Newsletters' section.
------------------------------------------------------------------------
3:56pm Posted to: http://support.silverstripe.com/gsoc/ticket/58#comment:5
* priority changed from blocker to medium
* summary changed from "Add" button is broken always in IE6 & IE7 and after reloadRecipients() is called in other browsers. to "Add" button is broken after reloadRecipients() is called

Markus found the fix for the ""Add" button is broken always in IE6 & IE7" part of this and aoneil merged it in! :)

r39709 | aoneil | 2007-08-07 16:33:11 -0500 (Tue, 07 Aug 2007) | 2 lines

Fix tinymce in IE - http://www.silverstripe.com/google-summer-of-code-forum/flat/3618

Now I need to test and make sure it still works after reloadRecipients() is called.
(16:01:16) Matt`SS: kinda gets cut off there lol
(16:02:05) elijahlofgren: yeah, I seems Cogito (a higher level tool for git) automatically adds line breaks. I've set $noisy = 1; so that all lines of message will be sent to CIA :)
4:02pm Confirmed that after reloadRecipientsList() is called in Firefox, the "Add" button does not work.
(16:02:49) Matt`SS: ah I see - that output is coming from your git repo?
(16:03:28) elijahlofgren: yes, I commit there before committing to gsoc SVN. So when I get something working I can comitt it to git, then after cleaning up the code, commit to gsoc SVN.
(16:06:04) Matt`SS: true true
4:17pm Going to see if Add button works after reloadRecipientsList() is called on 2.0.2b
4:19pm Hmm.. It does work. Going to try code like was used in 2.0.2b.....
(16:33:11) NC: hello again :p
(16:33:28) elijahlofgren: thanks. Had to reset router so my mom's PC would work. ;)
(16:33:54) NC: in the mood to answer a noob question?
(16:34:26) elijahlofgren: sure
4:37pm Using old 2.0.2b JS code does not actually update the list.
Maybe need to try using outerHTML with:
#Form_EditForm_Recipients
(16:36:52) NC: i'm trying to acheive a menu structure where the homepage shows the 2nd level menu, each 2nd level page shows the 2rd level menu, and the third level pages also show the third level menu (if that makes sense)
(16:37:12) NC: each 2nd level page shows the 3rd
(16:38:27) NC: i thought it should be a simple if level(1) menu(2) else menu(3)
(16:39:18) NC: but that shows nothing on the homepage
(16:40:05) elijahlofgren: Maybe use menu(1) instead of menu(2) (just guessing with this).
(16:40:29) elijahlofgren: NC: If you want, you can paste your template here: http://pastebin.com/ and I'll try it out.
(16:40:39) elijahs-supybot: Title: pastebin - collaborative debugging tool (at pastebin.com)
(16:41:29) NC: ta: http://pastebin.com/d23b9a656
(16:41:38) elijahs-supybot: Title: pastebin - collaborative debugging tool (at pastebin.com)
(16:43:15) elijahlofgren: It shows the top level menu for me.
(16:43:25) elijahlofgren: but you want 2nd level, correct?
(16:43:37) elijahlofgren: And are your 2nd level menu items children of your home page?
(16:44:50) NC: perhaps that's the problem. I have home/a/b/c all at the same level under site
(16:45:09) NC: but home seems to behave differently to the other pages at the same level
(16:46:10) elijahlofgren: NC: Which pages do you want displayed on home? a/b/c?
(16:46:43) NC: yes
(16:47:23) elijahlofgren: Then Menu(1) should do it for you (it'll also display Home though).
(16:48:04) NC: yep, it does, but then when clicking on a/b/c , the menu does not change to a.1, a.2, a.3
(16:48:46) elijahlofgren: that's probably because they are at the same level as home.
(16:49:04) elijahlofgren: You may want to click the "Reorganize" link in the Left part of the Admin and make them children of home.
(16:49:14) elijahlofgren: Then it will probably work like you want. ;)
(16:50:10) NC: yeah i think that's where i've gone wrong - i've just renamed the default pages. i'll try the reorganize, thanks for putting up with my daft questions elijah :D
(16:50:29) elijahlofgren: no problem. SilverStripe takes some getting used to. ;)
(16:51:57) NC: erm, i've dragged the pages around - nice feature - but i don't see how to save the changes?
(16:52:51) elijahlofgren: NC: well, currently in SS 2.0 you need to click on each one and then do "Publish". But the faster way is to go to /admin/publishall
(16:53:11) elijahlofgren: In 2.1 there will hopefully be a publish-all type button in the left frame.
(16:53:26) elijahlofgren: For now we have to put of with the ugly /admin/publishall script
(16:54:42) NC: publishall - very useful to know
(16:54:46) elijahlofgren: back. Kopete keeps crashing, might need to go back to irssi ;)
(16:54:54) NC: now I'm just using control children
(16:55:01) NC: works great
(16:55:18) elijahlofgren: Indeed. Probably publishall should be more documented.
(16:55:20) elijahlofgren: good.
(16:56:34) NC: thx a lot - i'm really liking ss so far, just need to get my head around a few things - much more comprehendable than most other cms tho
(16:57:34) elijahlofgren: you're welcome, I just found SilverStripe this summer and I plan to migrate my website to it since I like it so much :)
(16:59:05) NC: that's what I just started doing yesterday. after about 20-30 pages it
gets a bit tedious maintaining the html directly, even using php/includes
(16:59:45) Matt`SS: Good to hear... I like it too, but then again I would, working for the company and all :P
(17:00:02) Matt`SS: Thanks for helping out elijah :)
(17:00:30) elijahlofgren: Matt`SS: you're welcome. :)
4:59pm Ok, even using $('Form_EditForm_Recipients').outerHTML does not work. I think I'll just get rid of reloadRecipientsList() entirely and "just add a "Reload recipients list" link that calls:

$('Form_EditForm').getPageFromServer($('Form_EditForm_ID').value, 'recipients'); "
5:21pm Yes! Finally got it working using a link! :)
(17:25:51) CIA-34: Silverstripe-elijah: elijahlofgren cms-gsoc * rb865c8aadaae / (3 files in 3 dirs):
(17:25:52) CIA-34: Silverstripe-elijah: In order to fix: http://support.silverstripe.com/gsoc/ticket/58 "Add"
(17:25:52) CIA-34: Silverstripe-elijah: button is broken after reloadRecipientsList() is called do the following:
(17:25:52) CIA-34: Silverstripe-elijah: 1. After recipients are imported, show a link to "reload the Mailing List" which calls
(17:25:53) CIA-34: Silverstripe-elijah: reloadRecipientsList() instead of doing it automatically.
(17:25:55) CIA-34: Silverstripe-elijah: 2. Simply call getPageFromServer() and focus the Recipients tab, instead of
(17:25:57) CIA-34: Silverstripe-elijah: only reloading the Recipients tab.
5:41pm Going to push to remote git repo and ask Sean about committing.
(17:44:23) elijahlofgren: halkyon: Sean, does this look ok? http://repo.or.cz/w/silverstripe-elijah.git?a=commitdiff;h=b865c8aadaae79142c062b52ea13f3a7ef954421
(17:44:30) elijahs-supybot: Title: Public Git Hosting - silverstripe-elijah.git/commitdiff (at repo.or.cz)
(17:45:27) elijahlofgren: basically I'm fixing a bug by making the user click a link to reload the mailing list. It's a reduction in code, plus Recipients are probably not imported often, so the extra click won't be too burdensome. :)
(17:49:23) elijahlofgren: the reason for not reloading automatically is so that the member can see the result of the import on the "Import" tab, because calling getPageFromServer reloads entire right frame, instead of just recipients tab.
5;50pm Need to test in Safari 3, IE6, and IE7.
(18:06:32) Matt`SS: ah, so CIA-34 is doing both repos. Cool.
6:09pm Handed something of to Markus: http://www.silverstripe.com/general-discussion/flat/3340?showPost=3723#post3723
(18:06:32) Matt`SS: ah, so CIA-34 is doing both repos. Cool.
(18:07:38) Matt`SS: elijahlofgren: Have you noticed the CIA bot changing IP addresses it connects from? The hostmask doesn't work anymore :P
(18:07:39) CIA-34: silverstripe: lperera * r39763 /open/modules/sharethis/trunk/README: Changes to the README file
(18:07:46) Matt`SS: Their blog says something about changing servers
(18:08:14) Matt`SS: but that was in april
(18:08:36) elijahlofgren: Matt`SS: I saw it leave and come back. Maybe they have multiple servers or something...,
(18:09:47) Matt`SS: Quite possibly
(18:10:04) Matt`SS: Can't make a hostmask for something that keeps changing like that :P
(18:10:16) Matt`SS: Will potter around in #cia and see if I can find anything
(18:11:48) Matt`SS: Did you set it up for #silverstripe elijahlofgren?
(18:11:51) elijahlofgren: Matt`SS: Think that adding the link to click after importing is ok? halkyon seems away/busy. ;)
(18:11:57) elijahlofgren: Matt`SS: yes. I'll find the page..
(18:12:37) Matt`SS: You want me to look at the code or just the idea? :)
(18:12:56) # User bfcapell joined channel #silverstripe
(18:13:02) elijahlofgren: Matt`SS: either one, whichever you don't mind doing. :)
(18:13:19) elijahlofgren: If you loging to cia.vc you should be able to setup the bot here: http://cia.vc/account/bots/3780/
(18:13:30) elijahs-supybot: Title: CIA.vc - Log in (at cia.vc)
(18:13:31) elijahlofgren: It's a "community-owned bot." :)
(18:13:35) Matt`SS: Heh, the idea sounds fine to me.
(18:13:39) Matt`SS: Ah ok, thanks :)
(18:13:40) halkyon: sorry guys
(18:13:44) halkyon: just been a bit busy today
(18:14:00) Matt`SS: The code looks good too, but I haven't used the newsletter system before :P
(18:14:11) elijahlofgren: halkyon: no problem. Does the idea sound find to you? Fix a bug by making user click a link after recipient import?
(18:14:26) halkyon: sounds fine to me
(18:14:58) halkyon: :-)
(18:15:03) Matt`SS: elijahlofgren: Is there a username/password? It's asking me to login :) Can you PM it to me?
(18:15:08) elijahlofgren: great. All 3 tickets I aimed for today will now be fixed. :)
(18:15:19) halkyon: I assume there's no 'auto' way of reloading it?
(18:15:24) elijahlofgren: Matt`SS: You can just create your own cia.vc account.
(18:15:33) elijahlofgren: halkyon: I tried *a lot* ;)
(18:15:36) halkyon: I mean you've probably already come to the conclusion that doing that would be difficult?
(18:15:40) halkyon: yeah :-)
(18:15:42) halkyon: I thought so
(18:15:44) Matt`SS: oooh right
(18:16:12) halkyon: fair enough - this is the better way, instead of just wasting time figuring out an auto loader, nice work Elijah :-)
(18:16:56) elijahlofgren: Thanks. I really want to get to the Bulk actions for left site tree before GSoC is over! 8)
6:17pm Testing in IE6, IE7, and Safari3 before getting ready to commit...
(18:22:33) halkyon: yeah!
(18:22:34) elijahlofgren: Nice, git patches can be applied with regular patch command, just need to tell path to file.
(18:22:35) halkyon: sounds great :-)
(18:24:55) Matt`SS: elijahlofgren: I can edit the silverstripe project but not the bot as far as I can see, but that's fine :)
(18:25:55) elijahlofgren: Matt`SS: Maybe you need to "add this bot to [your] inventory"
(18:26:09) elijahlofgren: I'll wonder how that is done...
(18:26:37) elijahlofgren: ah, http://cia.vc/account/bots/add/ "Add an IRC bot to your account. If no bot exists for the IRC channel you specify, one will be created automatically."
(18:26:49) elijahs-supybot: Title: CIA.vc - Log in (at cia.vc)
(18:26:58) elijahlofgren: Matt`SS: so I guess just add and tell it silverstripe and you'll be able to edit it. :)
(18:27:02) Matt`SS: ooh
(18:27:08) Matt`SS: it said it was going to add another bot
(18:27:18) Matt`SS: then i see under that, that it'll only add a new bot if there isn't one already
(18:29:20) elijahlofgren: :( "Unknown runtime error" on IE6 when clicking my "reload the Mailing List" link. Hopefully the IE7 Microsoft Script Editor debugger will be more useful.
(18:30:02) elijahlofgren: hopefully IE6 just doesn't like my href="javascript:reloadRecipientsList()" link.
(18:30:08) Matt`SS: haha, welcome to the wonderful world of ie6
(18:30:26) Matt`SS: a onclick="javascript:reloadRecipientList()"
(18:30:34) halkyon: that sounds like a normal way of onclick
(18:30:35) Matt`SS: unless onclick doesn't work in xhtml1.1 anymore
(18:30:41) halkyon: or href
(18:31:02) halkyon: it probably _does_ work, just not supported ;-)
(18:31:30) Matt`SS: well target is no longer supported, never did find out why
(18:31:31) halkyon: the validator will just annoy us with 'blah blah proprietry value'
(18:31:50) halkyon: target? yeah, why isn't that? Using javascript is stupid, if the user turns it off
(18:32:00) halkyon: :/
(18:32:28) halkyon: I would've thought opening a popup using non-js techniques was far more robust
(18:34:00) elijahlofgren: href="#" onclick="javascript:top.reloadRecipientsList()" works in IE6. Thanks! :)
(18:34:23) Matt`SS: sweet :)
(18:34:28) halkyon: nice
(18:34:39) halkyon: too little js to separate that into a separate file, I guess
(18:34:47) halkyon: I mean it wouldn't be worth it
(18:35:13) halkyon: Elijah: will you be doing bits and pieces of work still, after the google period? :-)
(18:35:25) elijahlofgren: I think so. I could put it in the
(18:38:24) Matt`SS: NewsletterAdmin.js would be a good place for it?
(18:38:38) Matt`SS: elijahlofgren: True
(18:38:45) elijahlofgren: in the code, so I'll just add a Behaviour call in Newsletter_RecipientImportField.ss ;)
(18:38:52) elijahlofgren: gets called to eat supper.
(18:38:58) elijahlofgren: Be back later! :)
(18:39:13) halkyon: yeah, I guess these inconsistencies would be good to cleanup
(18:39:23) halkyon: but for now, if there's already newsletter js included in the header, just add it in there
(18:39:50) elijahlofgren: These are the ones included:


(18:39:55) elijahlofgren: :: runs off :: ;)
(18:42:46) Matt`SS: oh ok, there's no newsletteradmin, odd.
(18:42:59) Matt`SS: Either just a